From: Alan Mackenzie <acm@muc.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: "N. Jackson" <nljlistbox2@gmail.com>, 21275@debbugs.gnu.org
Subject: bug#21275: 24.5; Selection deleted with electric pair mode in cc mode
Date: Thu, 20 Aug 2015 21:55:06 +0000 [thread overview]
Message-ID: <20150820215506.GC3105@acm.fritz.box> (raw)
In-Reply-To: <f63c0384-3e79-41c6-ba1b-b279b6bd170a@default>
Hello, Drew.
On Thu, Aug 20, 2015 at 02:35:43PM -0700, Drew Adams wrote:
> > > +(defun delete-selection-uses-region-p ()
> >
> > The way I read it, this name says "a function which tells us if
> > delete-selection uses the region".
> No idea what this is all about, ....
It's for when delete-selection-mode and electric-pair-mode are both
enabled. What was happening (in C Mode, etc.) was that the user would
mark an object and type "(", expecting e-p-m to put a pair of parens
around the marked object; however d-s-m got in first, and deleted
(?killed) the region before the parens were put around the now empty
region.
There was already a solution for this for when "(" is bound to
self-insert-command - this is fairly arcane, and involves setting a
particular variable to function which returns t in the pertinent
circumstances.
This function was previously coded as a lambda. However, I needed to
use it for the pertinent CC Mode functions too, so I extracted it into a
defun, giving it the name `delete-selection-uses-region-p'. The
"delete-seleection" bit is the prefix, shared by the other
de\(fun\|var\)s in the file.
> .... but if this is for `electric-pair-mode' and not for
> `delete-selection-mode' then the name should reflect that - call it
> `electric-pair-SOMETHING'.
It's for when BOTH minor modes are enabled, to enable them to play
nicely with eachother. But it's in delsel.el, hence the prefix.
> Is this something that `delete-selection-mode' needs? Or is it
> for something else?
See above.
> > > + "Return non-nil when the current command uses the region.
> What does it mean for a command to "use the region"?
That isn't very good, is it? It basically means, from e-p-m's point of
view "I'm going to be "using" the region, so don't you go and delete
it!".
> > It's not about "the current command" but about self-insert-command
> > (which may be the current command or may be called by the current
> > command).
> What does it mean for such a command (or any other command) to
> "use the region"? That info should presumably be in the doc string.
I think you're right, here. I'll have another look at it.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2015-08-20 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 13:31 bug#21275: 24.5; Selection deleted with electric pair mode in cc mode N. Jackson
[not found] ` <mailman.8417.1439731993.904.bug-gnu-emacs@gnu.org>
2015-08-18 15:04 ` Alan Mackenzie
2015-08-18 16:43 ` N. Jackson
2015-08-19 21:52 ` Stefan Monnier
[not found] ` <jwv37zfosr4.fsf-monnier+emacsbugs@gnu.org>
2015-08-20 21:35 ` Drew Adams
2015-08-20 21:55 ` Alan Mackenzie [this message]
2015-08-21 5:46 ` Drew Adams
2015-08-21 13:42 ` Stefan Monnier
2015-08-21 15:01 ` Drew Adams
2015-08-19 17:22 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820215506.GC3105@acm.fritz.box \
--to=acm@muc.de \
--cc=21275@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=nljlistbox2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.