From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Damien Wyart Newsgroups: gmane.emacs.devel Subject: Re: When was a change installed? Date: Wed, 19 Aug 2015 12:16:32 +0200 Message-ID: <20150819101632.GA32499@brouette> References: <87vbcbhbup.fsf@gnu.org> <877forlhww.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1439979461 29254 80.91.229.3 (19 Aug 2015 10:17:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Aug 2015 10:17:41 +0000 (UTC) Cc: Bastien , Andreas Schwab , Richard Stallman , emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 19 12:17:34 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZS0R0-00050W-Eh for ged-emacs-devel@m.gmane.org; Wed, 19 Aug 2015 12:17:30 +0200 Original-Received: from localhost ([::1]:33088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS0Qz-0004Th-T8 for ged-emacs-devel@m.gmane.org; Wed, 19 Aug 2015 06:17:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS0QD-0003oc-S8 for emacs-devel@gnu.org; Wed, 19 Aug 2015 06:16:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZS0QD-0007Ab-22 for emacs-devel@gnu.org; Wed, 19 Aug 2015 06:16:41 -0400 Original-Received: from smtp-153-wednesday.nerim.net ([194.79.134.153]:46980 helo=maiev.nerim.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS0Q7-000785-8p; Wed, 19 Aug 2015 06:16:35 -0400 Original-Received: from brouette (damien.wyart.pck.nerim.net [213.41.145.138]) by maiev.nerim.net (Postfix) with ESMTP id 2532E2E021; Wed, 19 Aug 2015 12:16:33 +0200 (CEST) Original-Received: by brouette (Postfix, from userid 1000) id E900B38000CF; Wed, 19 Aug 2015 12:16:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <877forlhww.fsf@gmx.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-Received-From: 194.79.134.153 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188947 Archived-At: > > > $ git grep lax-whitespace */ChangeLog* > > > without the single quotes works for me. > > That's not the same, as the glob is expanded by the shell before git > > can see it. * Stephen Berman [2015-08-19 11:57]: > The error message by git, which I also get on invoking > git grep lax-whitespace '*/ChangeLog.*' > says "Use '--' to separate paths from revisions, like this: 'git > [...] -- [...]'", and indeed, when I run > git grep lax-whitespace -- '*/ChangeLog.*' > it outputs 26 matching lines. Invoking > git grep lax-whitespace */ChangeLog* > outputs only 25 of thos lines, all from lisp/; missing is > "doc/emacs/ChangeLog.1: (Replace): Document replace-lax-whitespace." > which the other output contains. > So you're right there's a difference, but apparently the '--' is necessary. I guess Andreas is using git 2.5.0, where '--' is not necessary anymore in this case. Here is the corresponding item from the release notes: ,---- | * A heuristic we use to catch mistyped paths on the command line | "git " is to make sure that all the non-rev | parameters in the later part of the command line are names of the | files in the working tree, but that means "git grep $str -- \*.c" | must always be disambiguated with "--", because nobody sane will | create a file whose name literally is asterisk-dot-see. Loosen the | heuristic to declare that with a wildcard string the user likely | meant to give us a pathspec. `---- -- Damien