From: floriansbriefe@gmail.com
To: martin rudalics <rudalics@gmx.at>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: frame.el: call before-make-frame-hook earlier in make-frame
Date: Fri, 31 Jul 2015 09:40:34 +0200 [thread overview]
Message-ID: <20150731074034.GA78288@csr-pc9.zib.de> (raw)
In-Reply-To: <55BB1F2C.8070205@gmx.at>
> > I would like to propose to call the before-make-frame-hook in the function
> > make-frame *before* retrieving the parameters of the new frame
> > (window-system-default-frame-alist and default-frame-alist) and not after.
> >
> > That way, one could dynamically set these variables inside the hook, e.g. to
> > create the new frame under the current position of the mouse cursor.
>
> We could easily do that. But encouraging users to set a variable called
> `default-frame-alist' in a hook is probably a very bad advice. Where
> would you change the default value back after you're done with making
> the frame? In `after-make-frame-functions'?
As the hook is registered, the hook will always adjust the 'default-frame-alist'
and thereby make its value dynamic. There is no need to restore the former default.
But I see your point, that it is a kind of hack.
> Creating a frame under the mouse cursor should be done by a special
> function that calls `make-frame' with the mouse position passed via the
> `left' and `top' PARAMETERS thus _overriding_ any default parameters.
> Please tell us if and why such a function would not be practicable for
> you.
That is a viable solution, but it has the drawback that you have to override a
default key-binding (C-x 5 2) with your own make-frame function and that you do
not benefit from the nice things that 'make-frame-command' additionally does for
you a) at the moment (setting the focus to the new frame etc) and b) potentially
in future emacs releases. Thats why I would prefer using the hook. Thats what
hooks are for: Adjusting behaviour with minimal invasion.
Cheers,
Florian
next prev parent reply other threads:[~2015-07-31 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 11:00 frame.el: call before-make-frame-hook earlier in make-frame Florian
2015-07-30 15:34 ` Stephen Leake
2015-07-31 7:09 ` martin rudalics
2015-07-31 7:40 ` floriansbriefe [this message]
2015-07-31 9:55 ` martin rudalics
2015-07-31 10:38 ` floriansbriefe
2015-08-01 10:50 ` martin rudalics
2015-08-03 9:16 ` Florian
2015-08-03 10:41 ` martin rudalics
2015-08-03 14:57 ` Eli Zaretskii
2015-08-03 21:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731074034.GA78288@csr-pc9.zib.de \
--to=floriansbriefe@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.