From: Pierre Lorenzon <devel@pollock-nageoire.net>
To: monnier@iro.umontreal.ca
Cc: 20914@debbugs.gnu.org
Subject: bug#20914: eieio/slot/group
Date: Wed, 01 Jul 2015 06:02:28 +0200 (CEST) [thread overview]
Message-ID: <20150701.060228.1839196597497012994.devel@pollock-nageoire.net> (raw)
In-Reply-To: <jwv8ub1ysqr.fsf-monnier+emacsbugs@gnu.org>
From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: bug#20914: eieio/slot/group
Date: Tue, 30 Jun 2015 14:09:20 -0400
>> The problem comes from use of `copy-sequence' in
>> `eieio-copy-parents-into-subclass' function of eieio-core. this
>> copy is not reccursive as explained in code comment but it
>> should be ! There's a joined patch that fixes the bug.
>
> Thanks for the investigation. I think the fix should be
Sure it is better to have a true copier for
cl--slot-descriptor.
> applied deeper. Can you confirm that the patch below works for you
unfortunately it does not ! I modified cl-preloaded.el
recompiled it but once restarting emacs my example classes do
not havae suitable properties. When doing Ch f
cl--copy-slot-descriptor I get that it is an alias for
copy-sequence as it was before and not the function defined
by the new definition you gave. Moreover if I force
cl-prelaoded.el to be loaded I get the correct definition. I
suspect that things are not loaded as they should but why
....
> as well?
>
>
> Stefan
>
>
> diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el
> index ed0639b..2e9bdde 100644
> --- a/lisp/emacs-lisp/cl-preloaded.el
> +++ b/lisp/emacs-lisp/cl-preloaded.el
> @@ -195,7 +195,7 @@
> (:constructor nil)
> (:constructor cl--make-slot-descriptor
> (name &optional initform type props))
> - (:copier cl--copy-slot-descriptor))
> + (:copier nil))
> ;; FIXME: This is actually not used yet, for circularity reasons!
> "Descriptor of structure slot."
> name ;Attribute name (symbol).
> @@ -205,6 +205,11 @@
> ;; :documentation, :protection, :custom, :label, :group, :printer.
> (props nil :type alist))
>
> +(defun cl--copy-slot-descriptor (slot)
> + (let ((new (copy-sequence slot)))
Are you sure that a copy-sequence will be enough here ? props
themselves are sequences hence they will be referenced by
this copy-sequence not copied. I think that a copy-tree
should be used here.
> + (cl-callf copy-sequence (cl--slot-descriptor-props new))
> + new))
> +
> (cl-defstruct (cl--class
> (:constructor nil)
> (:copier nil))
Ok I'll try to understand why it does not
work. I'll probably learn something in this
history and that's good !
Pierre
next prev parent reply other threads:[~2015-07-01 4:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 6:02 bug#20914: eieio/slot/group Pierre Lorenzon
2015-06-29 4:31 ` Pierre Lorenzon
2015-06-29 17:29 ` Pierre Lorenzon
2015-06-30 18:09 ` Stefan Monnier
2015-07-01 4:02 ` Pierre Lorenzon [this message]
2015-07-01 6:35 ` Pierre Lorenzon
2015-07-01 13:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701.060228.1839196597497012994.devel@pollock-nageoire.net \
--to=devel@pollock-nageoire.net \
--cc=20914@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.