all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: Problem with undo and text properties.
Date: Mon, 13 Apr 2015 19:10:40 +0000	[thread overview]
Message-ID: <20150413191040.GA6324@acm.fritz.box> (raw)
In-Reply-To: <jwvwq1lmooa.fsf-monnier+emacs@gnu.org>

Hello, Stefan.

Sorry for the delay in responding.  My network connection went down on
Thursday afternoon, and I had to wait until this morning to get it back.
You've got to love Deutsche Telekom.  :-(

[Context: load medium sized file.h.  C-x h, M-w, M->, C-y, C-x u.  The
C-x u goes slowly.]

On Thu, Apr 09, 2015 at 09:17:04AM -0400, Stefan Monnier wrote:
> > However, if you then undo this with C-x u, it takes almost forever to
> > complete.  The reason is that in the undo list there are lots (~6500) of
> > text property entries like

> >     (nil fontified nil 92222 . 92237)

> The problem is that those entries shouldn't be there in the first place.
> Whoever puts them there needs a with-silent-modification.

1. M-w puts the string-version-of-the-entire-file (including text
properties) into the kill ring.
2. C-y first appends that string to the buffer, ...
3. ... then separately removes the yank-excluded-properties from the
buffer, creating (nil fontified nil 92222. 92237) in buffer-undo-list in
so doing.

The part of C-y that does 3 is remove-yank-excluded-properties.  I think
you're suggesting we put a with-silent-modification around the critical
bits in remove-yank-excluded-properties.  Maybe I'll try that.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2015-04-13 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 11:10 Problem with undo and text properties Alan Mackenzie
2015-04-09 11:19 ` João Távora
2015-04-09 13:17 ` Stefan Monnier
2015-04-13 19:10   ` Alan Mackenzie [this message]
2015-04-13 21:23     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413191040.GA6324@acm.fritz.box \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.