From: Koichi Arakawa <arakawa@pp.iij4u.or.jp>
To: eliz@gnu.org
Cc: 20264@debbugs.gnu.org
Subject: bug#20264: [PATCH] fix: w32_executable_type() causes a segmentation fault
Date: Mon, 06 Apr 2015 18:48:11 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=)) [thread overview]
Message-ID: <20150406.184811.1180773812210980075.arakawa@pp.iij4u.or.jp> (raw)
In-Reply-To: <83a8yllm54.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> wrote:
>> for ( ; imports->Name; imports++)
>> {
>> char * dllname = RVA_TO_PTR (imports->Name, section,
>> executable);
>>
>> + if (imports->Name < base || dllname >= base + real_size)
>> + break;
>> +
>
> Shouldn't that "break" be "continue" instead? IOW, shouldn't we try
> all the other entries in the DLL import list?
I apologize insufficient research. The *illegal* dllname actually
points to another section. So the previous patch is wrong and it
should be as follows.
diff --git a/src/w32proc.c b/src/w32proc.c
index 7d982f8..5ae55ff 100644
--- a/src/w32proc.c
+++ b/src/w32proc.c
@@ -1625,6 +1625,7 @@ w32_executable_type (char * filename,
for ( ; imports->Name; imports++)
{
+ section = rva_to_section (imports->Name, nt_header);
char * dllname = RVA_TO_PTR (imports->Name, section,
executable);
--
Koichi Arakawa
next prev parent reply other threads:[~2015-04-06 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 3:23 bug#20264: [PATCH] fix: w32_executable_type() causes a segmentation fault Koichi Arakawa
2015-04-06 8:02 ` Eli Zaretskii
2015-04-06 9:48 ` Koichi Arakawa [this message]
2015-04-06 10:30 ` Eli Zaretskii
2015-04-06 17:04 ` Koichi Arakawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406.184811.1180773812210980075.arakawa@pp.iij4u.or.jp \
--to=arakawa@pp.iij4u.or.jp \
--cc=20264@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.