From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rgm@gnu.org, nicolas@petton.fr, monnier@iro.umontreal.ca,
emacs-devel@gnu.org
Subject: Re: Emacs 24.5 second release candidate
Date: Fri, 3 Apr 2015 11:06:15 +0000 [thread overview]
Message-ID: <20150403110615.GA2867@acm.fritz.box> (raw)
In-Reply-To: <834moyqwb9.fsf@gnu.org>
Hello, Eli.
On Thu, Apr 02, 2015 at 08:22:50PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 2 Apr 2015 16:12:56 +0000
> > From: Alan Mackenzie <acm@muc.de>
> > Cc: rgm@gnu.org, nicolas@petton.fr, monnier@iro.umontreal.ca,
> > emacs-devel@gnu.org
> > > Do you have an estimation of how much time you will need?
> > Perhaps this evening, perhaps tomorrow morning. It's one of these nasty
> > little bugs which looks totally wierd and random until one stumbles upon
> > the cause, after which it takes 2 minutes to fix.
> > > Also, was this bug caused by a recent commit, and if so, which one?
> > No, I don't think it was. I think it was "unmasked" by a recent bug
> > "fix", d69e9f1c24f37f36af33b0468c5a4e100dbb09b6 from 2015-02-01. Oleh
> > Krehel, the OP of the pertinent bug #20245, says that with that change
> > reversed, the bug symptoms don't manifest themselves. I haven't checked
> > this yet, but it sounds plausible. That fix is actually incomplete,
> > requiring Monday/yesterday's fix to make it complete.
> > I'm beginning to come round to the view that perhaps it might be best
> > just to take d69e9f1c24f37f36af33b0468c5a4e100dbb09b6 out of Emacs 24.5,
> > as Oleh Krehel has explicitly suggested.
> Sounds plausible. Please share your opinions after you study the
> issue.
I now understand precisely what the problem is. Sorry it's taken me a
little longer than "perhaps tomorrow morning".
The problem is in `c-fl-decl-start', a routine called (indirectly) from
every `jit-lock-fontify-now'. It attempts to check whether `start' is
within a declaration.
It does this by calling `c-beginning-of-decl-1' with a 500 byte search
limit. c-b-o-d-1 wrongly returns the same value for "hit search limit"
as "found beginning of declaration".
So CC Mode's fontification is directed to start 500 bytes back, in the
middle of a #include directive. This is not immediately apparent, only
becoming visible at the next redisplay.
This is indeed an old bug, unmasked by the d69e.... change rather than
caused by it.
I don't want to try to fix this in a few hours; a few days would be more
realistic.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2015-04-03 11:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 20:33 Emacs 24.5 second release candidate Nicolas Petton
2015-04-01 21:42 ` Glenn Morris
2015-04-02 1:11 ` Stefan Monnier
2015-04-02 7:14 ` Nicolas Petton
2015-04-02 13:49 ` Nicolas Petton
2015-04-02 14:02 ` Alan Mackenzie
2015-04-02 14:50 ` Nicolas Petton
2015-04-02 15:26 ` Stefan Monnier
2015-04-02 16:08 ` Eli Zaretskii
2015-04-02 16:19 ` Alan Mackenzie
2015-04-02 17:24 ` Eli Zaretskii
2015-04-02 17:31 ` Alan Mackenzie
2015-04-02 21:45 ` Stefan Monnier
2015-04-02 15:21 ` Eli Zaretskii
2015-04-02 16:12 ` Alan Mackenzie
2015-04-02 17:22 ` Eli Zaretskii
2015-04-02 17:33 ` Alan Mackenzie
2015-04-03 11:06 ` Alan Mackenzie [this message]
2015-04-03 11:30 ` Eli Zaretskii
2015-04-03 11:51 ` Alan Mackenzie
2015-04-03 12:00 ` Eli Zaretskii
2015-04-03 12:29 ` Alan Mackenzie
2015-04-03 12:51 ` Eli Zaretskii
2015-04-04 7:45 ` Eli Zaretskii
2015-04-04 22:20 ` Nicolas Petton
2015-04-04 22:24 ` Drew Adams
2015-04-05 10:58 ` Nicolas Petton
2015-04-05 6:38 ` Eli Zaretskii
2015-04-03 7:28 ` Andreas Röhler
2015-04-03 11:57 ` Alan Mackenzie
2015-04-03 18:42 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403110615.GA2867@acm.fritz.box \
--to=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.