From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: arakawa@pp.iij4u.or.jp Newsgroups: gmane.emacs.bugs Subject: bug#20249: [PATCH] tramp: tramp-flush-directory-property loops infinitly. Date: Fri, 03 Apr 2015 09:31:21 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=)) Message-ID: <20150403.093121.1376099698840392615.arakawa@pp.iij4u.or.jp> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1428026004 17662 80.91.229.3 (3 Apr 2015 01:53:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Apr 2015 01:53:24 +0000 (UTC) To: 20249@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 03 03:53:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YdqnH-0002qI-Vg for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Apr 2015 03:53:12 +0200 Original-Received: from localhost ([::1]:60638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdqnG-0005Sc-RL for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Apr 2015 21:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdqnC-0005SN-Ga for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 21:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ydqn9-00019Q-9Q for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 21:53:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ydqn8-00019M-NS for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 21:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ydqn8-0005VS-C7 for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 21:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: arakawa@pp.iij4u.or.jp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Apr 2015 01:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20249 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142802592821097 (code B ref -1); Fri, 03 Apr 2015 01:53:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Apr 2015 01:52:08 +0000 Original-Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdqmE-0005UC-5Y for submit@debbugs.gnu.org; Thu, 02 Apr 2015 21:52:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49313) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdpWe-0003a6-Q3 for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWY-0006er-IC for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:51 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWY-0006en-FL for submit@debbugs.gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWX-0007aC-JF for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdpWT-0006eY-JL for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:49 -0400 Original-Received: from mo-sw1501.iij4u.or.jp ([210.130.239.241]:44085 helo=mo-sw.iij4u.or.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdpWS-0006eE-Pz for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2015 20:31:45 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Subject:From:Mime-Version:Content-Type: Content-Transfer-Encoding; i=arakawa@pp.iij4u.or.jp; s=20140530.iij4u; t= 1428021100; x=1429230700; bh=WNIAsgexbXN2iffkkoV/TDorQx+V68OwFhPmmKVbDU4=; b=MEd NLXTqcqsrsjbGDRJWtf3ulsIHy2n/uBsZ1/CIPVpTXQNnCmx2Rq2yygiPCsZZ1OqsfHr7wfQ1XHGh KnqlmRO7rpfzU9mJXlG7nDdLZMu/y5nSK1NVtfTWAkfoE24IImVR8bmbk2tqAQ2dpgaqU5OK7cMQY mK7AV5pYUqeBGsUET4nk2HASzFPpfHhER30eG/w4SiBp4bsibvlr5BybG3bLoyelrXDNDe3yKfdV0 Iva19d0+PpAtk+myAbKswn/8ue7mu1NfCPL5KVH6bQ030HWMNL4ZHKOboT/DgC6XCQDIzQF0YXILw zIqiqboYvG1J4Z17EyhBGISS0leyOgA==; Original-Received: by mo-sw.iij4u.or.jp (4u-mo-sw1501) id t330Ve2s007581; Fri, 3 Apr 2015 09:31:40 +0900 Original-Received: from localhost ([IPv6:2001:e41:a010:778a:7d27:3c3b:9313:6d87]) by mbox.iij4u.or.jp (4u-mbox1500) id t330VWb6017082 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 3 Apr 2015 09:31:39 +0900 X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Thu, 02 Apr 2015 21:52:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101145 Archived-At: Hi, When tramp-flush-directory-property called with 'directory' which ends in slash, directory-file-name removes the trailing slash but 'file-truename' operation doesn't necessarily remove it. In that case, directory and truename always differ and tramp-flush-directory-property called infinitely. Best regards, Koichi Arakawa --- lisp/ChangeLog | 5 +++++ lisp/net/tramp-cache.el | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 38e45d0..3f86a43 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-04-03 Koichi Arakawa + + * net/tramp-cache.el (tramp-flush-directory-property): Fix an + infinite loop when 'directory' ends in slash. + 2015-04-02 Stefan Monnier * abbrev.el (define-abbrev-table): Treat a non-string "docstring" as diff --git a/lisp/net/tramp-cache.el b/lisp/net/tramp-cache.el index 1e24ea5..a418eb5 100644 --- a/lisp/net/tramp-cache.el +++ b/lisp/net/tramp-cache.el @@ -188,7 +188,8 @@ Remove also properties of all files in subdirectories." (truename (tramp-get-file-property key directory "file-truename" nil))) ;; Remove file properties of symlinks. (when (and (stringp truename) - (not (string-equal directory truename))) + (not (string-equal directory truename)) + (not (string-equal (concat directory "/") truename))) (tramp-flush-directory-property key truename)) (tramp-message key 8 "%s" directory) (maphash -- 2.3.4