From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#20074: edebug tracing can't be stopped with 'S' Date: Mon, 16 Mar 2015 11:38:35 +0000 Message-ID: <20150316113835.GA3286@acm.fritz.box> References: <20150315195510.9240.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1426506025 17935 80.91.229.3 (16 Mar 2015 11:40:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Mar 2015 11:40:25 +0000 (UTC) Cc: 20074@debbugs.gnu.org, Mario Valencia To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 16 12:40:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXTNU-0002pP-BL for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Mar 2015 12:40:12 +0100 Original-Received: from localhost ([::1]:48518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXTNT-0004Yq-5z for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Mar 2015 07:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXTNP-0004Xj-Fx for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 07:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXTNL-0008Uw-9L for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 07:40:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXTNL-0008UZ-6J for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 07:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YXTNK-0002A4-K3 for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2015 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Mar 2015 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20074-submit@debbugs.gnu.org id=B20074.14265059438222 (code B ref 20074); Mon, 16 Mar 2015 11:40:02 +0000 Original-Received: (at 20074) by debbugs.gnu.org; 16 Mar 2015 11:39:03 +0000 Original-Received: from localhost ([127.0.0.1]:48150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXTMM-00028N-Hs for submit@debbugs.gnu.org; Mon, 16 Mar 2015 07:39:03 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:46729 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YXTMJ-000286-Uj for 20074@debbugs.gnu.org; Mon, 16 Mar 2015 07:39:00 -0400 Original-Received: (qmail 31275 invoked by uid 3782); 16 Mar 2015 11:38:57 -0000 Original-Received: from acm.muc.de (pD951850E.dip0.t-ipconnect.de [217.81.133.14]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 16 Mar 2015 12:38:56 +0100 Original-Received: (qmail 3651 invoked by uid 1000); 16 Mar 2015 11:38:35 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100518 Archived-At: Hello, Stefan. On Sun, Mar 15, 2015 at 11:12:52PM -0400, Stefan Monnier wrote: > > - (sit-for edebug-sit-for-seconds)) ; Force update and pause. > > + (if (not (sit-for edebug-sit-for-seconds)) > > + (setq edebug-stop t))) ; Force update and pause. > Looks much better, thanks. I wonder if the other sit-for call should do > the same. You mean for the one for when `edebug-execution-mode' is 'Trace-fast. I don't think that's the right solution. If we did that, some "S"s from Trace-fast would get caught by the "(if (input-pending)...)" at L+91, and the others will get caught by the "(sit-for 0)". Perhaps a better solution might be to move the "(if (input-pending) ...)" to just after these two "(sit-for ..)"s, and just before the call to edebug--recursive-edit. Then all the testing for input events will be done in the one place. What that `if' form does doesn't seem critical to the functionality, apart from setting `edebug-stop' to t - "(edebug-stop)" merely displays "STOP" in the echo area. > Stefan -- Alan Mackenzie (Nuremberg, Germany).