all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Barry Warsaw <barry@python.org>
To: emacs-devel@gnu.org
Subject: Re: save-excursion and the mark
Date: Tue, 24 Feb 2015 10:37:16 -0500	[thread overview]
Message-ID: <20150224103716.5cb7c25f@anarchist.wooz.org> (raw)
In-Reply-To: jwvsidxfddt.fsf-monnier+emacs@gnu.org

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Feb 22, 2015, at 11:44 PM, Stefan Monnier wrote:

>`save-excursion' is defined to save&restore the mark (as well as its
>being active or not).
>
>But I'm having a hard time finding a piece of code where we actually
>make use of this.

Won't this potentially break some poor user's code out there?  There's tons of
code that you'll never see because it's private.  save-excursion is documented
to save and restore mark, so people could be surprised by this API break, and
confused by their code suddenly breaking after an upgrade.  It seems risky.

Cheers,
-Barry

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-02-24 15:37 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23  4:44 save-excursion and the mark Stefan Monnier
2015-02-23 11:34 ` Oleh Krehel
2015-02-23 22:33   ` Stefan Monnier
2015-02-23 23:14     ` Oleh Krehel
2015-02-24  0:12       ` Artur Malabarba
2015-02-24  8:47         ` Oleh Krehel
2015-02-24  2:31   ` Alexis
2015-02-24  3:52     ` Stefan Monnier
2015-02-25  1:58       ` Yuri Khan
2015-02-24 15:37 ` Barry Warsaw [this message]
2015-02-24 19:27   ` Stefan Monnier
2015-02-24 20:11     ` Barry Warsaw
2015-02-24 20:49       ` Artur Malabarba
2015-02-25  3:01         ` Stefan Monnier
2015-02-25  3:25           ` Artur Malabarba
2015-02-25 16:31           ` Barry Warsaw
2015-02-25 16:42             ` Stefan Monnier
2015-02-25 17:17             ` Drew Adams
2015-02-25 18:30     ` Richard Stallman
2015-02-26 13:50       ` Stefan Monnier
2015-02-27  0:13         ` Richard Stallman
2015-02-27 13:49           ` Stefan Monnier
2015-02-27 23:46             ` Richard Stallman
2015-02-28 18:50               ` martin rudalics
2015-03-02  5:36                 ` Stefan Monnier
2015-03-02  5:35               ` Stefan Monnier
2015-03-02 21:05                 ` Richard Stallman
2015-03-03 16:34                   ` Stefan Monnier
2015-03-04 12:01                     ` Richard Stallman
2015-02-24 16:05 ` Andreas Röhler
2015-02-25  2:59   ` Stefan Monnier
2015-02-25 11:49     ` Andreas Röhler
2015-02-25 12:35       ` Ivan Shmakov
2015-02-25 13:05         ` Andreas Röhler
2015-02-25 14:00       ` Stefan Monnier
2015-02-25 17:13         ` Andreas Röhler
2015-02-25  9:18 ` Ivan Shmakov
2015-02-25 15:56   ` Eli Zaretskii
2015-04-06 18:45 ` Magnar Sveen
2015-04-07 21:37   ` Stefan Monnier
2015-04-08  1:57   ` Stefan Monnier
2015-04-14 16:08     ` Magnar Sveen
2015-04-14 20:16       ` Stefan Monnier
2015-04-15  4:14         ` Magnar Sveen
2015-04-15 12:53           ` Stefan Monnier
2015-04-15 13:49             ` Magnar Sveen
2015-04-15 14:59               ` Stefan Monnier
2015-04-18  1:02                 ` Daniel Colascione
2015-04-15 14:24           ` Richard Stallman
2015-04-15 15:16           ` Phillip Lord
2015-04-19 15:28         ` Oleh Krehel
2015-04-20  2:03           ` Stefan Monnier
2015-04-20  6:31         ` Andreas Röhler
2015-04-23 10:03 ` Frank Fischer
2015-05-28 17:42 ` Nicolas Richard
  -- strict thread matches above, loose matches on Subject: below --
2015-04-17 18:53 Lars Magne Ingebrigtsen
2015-04-18  4:26 ` Stefan Monnier
2015-04-18 12:30   ` Wolfgang Jenkner
2015-04-25 12:45   ` Lars Magne Ingebrigtsen
2015-04-25 13:23     ` Lars Magne Ingebrigtsen
2015-04-25 14:19       ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150224103716.5cb7c25f@anarchist.wooz.org \
    --to=barry@python.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.