From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Let input queue deal gracefully with up-events Date: Wed, 28 Jan 2015 14:58:49 +0000 Message-ID: <20150128145849.GA5107@acm.acm> References: <1422451883-6530-1-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1422457189 9148 80.91.229.3 (28 Jan 2015 14:59:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2015 14:59:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 28 15:59:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGU5r-00058h-9V for ged-emacs-devel@m.gmane.org; Wed, 28 Jan 2015 15:59:47 +0100 Original-Received: from localhost ([::1]:54000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGU5q-0007hX-Lr for ged-emacs-devel@m.gmane.org; Wed, 28 Jan 2015 09:59:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGU5Y-0007fc-UL for emacs-devel@gnu.org; Wed, 28 Jan 2015 09:59:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGU5U-00084s-Uk for emacs-devel@gnu.org; Wed, 28 Jan 2015 09:59:28 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:26193 helo=mail.muc.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGU5U-000832-Km for emacs-devel@gnu.org; Wed, 28 Jan 2015 09:59:24 -0500 Original-Received: (qmail 95849 invoked by uid 3782); 28 Jan 2015 14:59:22 -0000 Original-Received: from acm.muc.de (pD951AA92.dip0.t-ipconnect.de [217.81.170.146]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 28 Jan 2015 15:59:21 +0100 Original-Received: (qmail 5703 invoked by uid 1000); 28 Jan 2015 14:58:49 -0000 Content-Disposition: inline In-Reply-To: <1422451883-6530-1-git-send-email-dak@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181908 Archived-At: Hello, David. There's a solecism in your patch. (To be fair, it was also in the original). Please insert the word "being" at the place shown, between "before" and "presented". Thanks! On Wed, Jan 28, 2015 at 02:31:23PM +0100, David Kastrup wrote: > } > @@ -6249,16 +6253,18 @@ apply_modifiers_uncached (int modifiers, char *base, int base_len, int base_len_ > /* Since BASE could contain nulls, we can't use intern here; we have > to use Fintern, which expects a genuine Lisp_String, and keeps a > reference to it. */ > - char new_mods[sizeof "A-C-H-M-S-s-down-drag-double-triple-"]; > + char new_mods[sizeof "A-C-H-M-S-s-up-down-drag-double-triple-"]; > int mod_len; > { > char *p = new_mods; > - /* Only the event queue may use the `up' modifier; it should always > - be turned into a click or drag event before presented to lisp code. */ > - if (modifiers & up_modifier) > - emacs_abort (); > + /* Mouse events should not exhibit the `up' modifier; it should > + always be turned into a click or drag event before presented to ^^^^^ being > + lisp code. And there should not be more than one of > + up/down/click/drag anyway. But since Lisp events can be > + synthesized, we don't take exception to unexpected > + combinations */ -- Alan Mackenzie (Nuremberg, Germany).