Re: [PATCH] Let input queue deal gracefully with up-events

[Alan Mackenzie <acm@muc.de>]

Hello, David.

There's a solecism in your patch.  (To be fair, it was also in the
original).  Please insert the word "being" at the place shown, between
"before" and "presented".

Thanks!

On Wed, Jan 28, 2015 at 02:31:23PM +0100, David Kastrup wrote:

>  	}
> @@ -6249,16 +6253,18 @@ apply_modifiers_uncached (int modifiers, char *base, int base_len, int base_len_
>    /* Since BASE could contain nulls, we can't use intern here; we have
>       to use Fintern, which expects a genuine Lisp_String, and keeps a
>       reference to it.  */
> -  char new_mods[sizeof "A-C-H-M-S-s-down-drag-double-triple-"];
> +  char new_mods[sizeof "A-C-H-M-S-s-up-down-drag-double-triple-"];
>    int mod_len;

>    {
>      char *p = new_mods;

> -    /* Only the event queue may use the `up' modifier; it should always
> -       be turned into a click or drag event before presented to lisp code.  */
> -    if (modifiers & up_modifier)
> -      emacs_abort ();
> +    /* Mouse events should not exhibit the `up' modifier; it should
> +       always be turned into a click or drag event before presented to
                                                          ^^^^^
                                                          being

> +       lisp code.  And there should not be more than one of
> +       up/down/click/drag anyway.  But since Lisp events can be
> +       synthesized, we don't take exception to unexpected
> +       combinations */

-- 
Alan Mackenzie (Nuremberg, Germany).