From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Klausner Newsgroups: gmane.emacs.bugs Subject: bug#19658: unportable test(1) comparison operator Date: Fri, 23 Jan 2015 00:10:07 +0100 Message-ID: <20150122231007.GA24371@danbala.tuwien.ac.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="PNTmBPCT7hxwcZjr" X-Trace: ger.gmane.org 1421968278 27113 80.91.229.3 (22 Jan 2015 23:11:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Jan 2015 23:11:18 +0000 (UTC) To: 19658@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 23 00:11:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YEQu6-0000xx-IX for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jan 2015 00:11:10 +0100 Original-Received: from localhost ([::1]:56468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQu6-0001AD-0M for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jan 2015 18:11:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQu2-00017G-G1 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQtz-0005P7-4x for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:11:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtz-0005P2-1R for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YEQty-0006Cu-Lv for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Klausner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jan 2015 23:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142196822323803 (code B ref -1); Thu, 22 Jan 2015 23:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Jan 2015 23:10:23 +0000 Original-Received: from localhost ([127.0.0.1]:53307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtK-0006Br-JM for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtI-0006Bd-6E for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQtB-0005DS-TQ for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:14 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtB-0005DO-RX for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtA-0000qm-O9 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQt7-0005Cs-J4 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:12 -0500 Original-Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.64]:50096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQt7-0005Ak-Cp for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:09 -0500 Original-Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id B8479A5AA; Fri, 23 Jan 2015 00:10:07 +0100 (CET) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98606 Archived-At: --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! In emacs git as of yesterday, test/indent/shell.sh contains the unportable '==' comparison operator for test(1) -- only bash supports that, not even GNU coreutils' test(1). Please use '=' instead; see attached patch. Thanks, Thomas P.S.: I know it's not intended to be executed, but I'd like to avoid having bad examples around :) --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-af --- test/indent/shell.sh.orig 2011-02-16 02:00:00.000000000 +0000 +++ test/indent/shell.sh @@ -70,7 +70,7 @@ help2 EOF2 } bar () { - if [ $# == 0 ]; then + if [ $# = 0 ]; then while f # KNOWN INDENT BUG do --PNTmBPCT7hxwcZjr--