From: Thomas Klausner <tk@giga.or.at>
To: 19658@debbugs.gnu.org
Subject: bug#19658: unportable test(1) comparison operator
Date: Fri, 23 Jan 2015 00:10:07 +0100 [thread overview]
Message-ID: <20150122231007.GA24371@danbala.tuwien.ac.at> (raw)
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
Hi!
In emacs git as of yesterday, test/indent/shell.sh contains the
unportable '==' comparison operator for test(1) -- only bash supports
that, not even GNU coreutils' test(1).
Please use '=' instead; see attached patch.
Thanks,
Thomas
P.S.: I know it's not intended to be executed, but I'd like to avoid
having bad examples around :)
[-- Attachment #2: patch-af --]
[-- Type: text/plain, Size: 264 bytes --]
--- test/indent/shell.sh.orig 2011-02-16 02:00:00.000000000 +0000
+++ test/indent/shell.sh
@@ -70,7 +70,7 @@ help2
EOF2
}
bar () {
- if [ $# == 0 ]; then
+ if [ $# = 0 ]; then
while
f # KNOWN INDENT BUG
do
next reply other threads:[~2015-01-22 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:10 Thomas Klausner [this message]
2015-01-25 3:03 ` bug#19658: unportable test(1) comparison operator Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122231007.GA24371@danbala.tuwien.ac.at \
--to=tk@giga.or.at \
--cc=19658@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.