Re: Bug: multiple property drawers generated for repeated tasks with org-log-done set to 'note [8.3beta (release_8.3beta-621-gf212f7) @ /path/to/org-mode/lisp/]

Re: Bug: multiple property drawers generated for repeated tasks with org-log-done set to 'note [8.3beta (release_8.3beta-621-gf212f7) @ /path/to/org-mode/lisp/]

[Nicolas Goaziou]

Hello,

"Bradley M. Kuhn" <bkuhn@ebb.org> writes:

> I'm running org-mode directly out of master branch.  I updated to
> f212f7cf0d03c8f7abd22ffa6de2e5c46b19a266 (current master at time of
> writing) just to make sure the bug below hadn't been fixed recently.  It
> seems to still be present.  Here it is:
>
> With a minimal org mode setup with 'emacs -Q' and no other
> configuration, set these:
>
>   (setq org-log-done t)
>   (setq org-log-done 'note)
>
> then, in an org file (even an empty one), do this:
>
> * TODO test
>   SCHEDULED: <2014-12-06 Sat +1w>
>
> Then, do C-c C-t (org-todo) to mark as done and let it repeat.
> Then, do C-c C-t (org-todo) again.
>
> You'll end up with something like:
>
> * TODO test
>   SCHEDULED: <2015-01-31 Sat +1w>
>   - CLOSING NOTE [2014-12-06 Sat 21:52]
>   :PROPERTIES:
>   :LAST_REPEAT: [2014-12-06 Sat 21:52]
>   :END:
>   - CLOSING NOTE [2014-12-06 Sat 21:51]
>   :PROPERTIES:
>   :LAST_REPEAT: [2014-12-06 Sat 21:51]
>   :END:

That should be fixed. Thank you for reporting it.

Regards,

-- 
Nicolas Goaziou

Bug: addt'l multiple property drawers situations when org-log-done set to 'note [8.3beta (release_8.3beta-621-gf212f7) @ /path/to/org-mode/lisp/]

[Bradley M. Kuhn]

Nicolas,

Thanks for fixing that bug so quickly.  I grabbed the lastest master
and it seems the bug is definitely fixed.

I however still have a related bug:  I have many entries where the PROPERTIES
drawer is at the bottom of a long set of TODO notes.  Mine look like this:

** TODO Monthly Accounting: Reconcile Payment report.
   SCHEDULED: <2014-10-07 Tue 08:00 ++1m>
   - State "DONE"       from "TODO"       [2014-09-05 Fri 19:12] \\
     Finished through <2014-09-02 Tue>
   - State "DONE"       from "TODO"       [2014-06-16 Mon 09:28] \\
     Did this through <2014-05-30 Fri>.
   - State "TODO"       from ""           [2014-06-12 Thu 22:40] \\
     The monthly payment report can be downloaded.
   :PROPERTIES:
   :LAST_REPEAT: [2014-09-05 Fri 19:12]
   :END:

I still get a second property drawer when I cycle these repeating TODOs, if I
have:

(setq org-log-done 'note)

Same happens with ones like this, BTW::

* TODO Testing.
  SCHEDULED: <2014-12-28 Sun ++1w>
  - CLOSING NOTE [2014-12-07 Sun 19:25]
  - CLOSING NOTE [2014-12-07 Sun 19:25]
  :PROPERTIES:
  :LAST_REPEAT: [2014-12-07 Sun 19:25]
  :END:

It seems the new code intends to keep properties draw at the top of an entry,
but shouldn't it respect the positioning of the PROPRIETIES draw regardless
of where it is in the entry?

Thanks again for your responsiveness!

   -- bkuhn

Re: Bug: addt'l multiple property drawers situations when org-log-done set to 'note [8.3beta (release_8.3beta-621-gf212f7) @ /path/to/org-mode/lisp/]

[Nicolas Goaziou]

Hello,

"Bradley M. Kuhn" <bkuhn@ebb.org> writes:

> I however still have a related bug:  I have many entries where the PROPERTIES
> drawer is at the bottom of a long set of TODO notes.  Mine look like this:
>
> ** TODO Monthly Accounting: Reconcile Payment report.
>    SCHEDULED: <2014-10-07 Tue 08:00 ++1m>
>    - State "DONE"       from "TODO"       [2014-09-05 Fri 19:12] \\
>      Finished through <2014-09-02 Tue>
>    - State "DONE"       from "TODO"       [2014-06-16 Mon 09:28] \\
>      Did this through <2014-05-30 Fri>.
>    - State "TODO"       from ""           [2014-06-12 Thu 22:40] \\
>      The monthly payment report can be downloaded.
>    :PROPERTIES:
>    :LAST_REPEAT: [2014-09-05 Fri 19:12]
>    :END:
>
> I still get a second property drawer when I cycle these repeating TODOs, if I
> have:
>
> (setq org-log-done 'note)
>
> Same happens with ones like this, BTW::
>
> * TODO Testing.
>   SCHEDULED: <2014-12-28 Sun ++1w>
>   - CLOSING NOTE [2014-12-07 Sun 19:25]
>   - CLOSING NOTE [2014-12-07 Sun 19:25]
>   :PROPERTIES:
>   :LAST_REPEAT: [2014-12-07 Sun 19:25]
>   :END:
>
> It seems the new code intends to keep properties draw at the top of an entry,
> but shouldn't it respect the positioning of the PROPRIETIES draw regardless
> of where it is in the entry?

This is a recent change in master. PROPERTIES drawer is only recognized
as such when at the top of the section, possibly after a planning info
line.

You may want to look into ORG-NEWS file, there's a function to help you
fix old documents.


Regards,

-- 
Nicolas Goaziou

Re: Bug: addt'l multiple property drawers situations when org-log-done set to 'note [8.3beta (release_8.3beta-621-gf212f7) @ /path/to/org-mode/lisp/]

[Bradley M. Kuhn]

Nicolas Goaziou wrote:
> This is a recent change in master. PROPERTIES drawer is only recognized as
> such when at the top of the section, possibly after a planning info line.

I apologize for not reading ORG-NEWS before reporting the bug... er,
feature. ;)


> You may want to look into ORG-NEWS file, there's a function to help you
> fix old documents.

Thanks for taking the time to tell me where to look!  Yes, it was right
there. I'm sorry for taking up your time with pointing me to the obvious
place. :)


   -- bkuhn