From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el. Date: Wed, 3 Dec 2014 14:53:58 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20141203195358.GA13738@thyrsus.com> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <87wq687cmk.fsf@engster.org> Reply-To: esr@thyrsus.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1417636469 26995 80.91.229.3 (3 Dec 2014 19:54:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 19:54:29 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: David Engster Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 20:54:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwG0F-0005ok-NO for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 20:54:23 +0100 Original-Received: from localhost ([::1]:43108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG0F-0003wv-Du for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 14:54:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFzv-0003qx-SR for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:54:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwFzr-00070S-Cm for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:54:03 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:58538 helo=snark.thyrsus.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFzr-000700-25 for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:53:59 -0500 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id 77DA5382B39; Wed, 3 Dec 2014 14:53:58 -0500 (EST) Content-Disposition: inline In-Reply-To: <87wq687cmk.fsf@engster.org> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 71.162.243.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178764 Archived-At: David Engster : > Stefan Monnier writes: > >> +before descending into it, and if nil is returned at that point > >> +the descent will be prevented. Directory entries are sorted with > >> +string-lessp" > > ^^^ > > Don't forget to punctuate your docstrings. > > And string-lessp should be quoted, but it doesn't matter since AFAICS > that sentence isn't true anyway. Huh? They're from directory-files, which according to its documentation sorts the names with string-lessp. > Apart from that, I find this function confusing. Why not simply call > ACTION with the full filename instead of splitting in into DIR and the > filename sans the directory part (where the latter might actually be a > subdirectory)? Because that's how the well-tested code I found in the EmacsWiki cookbook section worked. -- Eric S. Raymond