From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Zheng Newsgroups: gmane.emacs.bugs Subject: bug#19179: 25.0.50; Build failure with wrong version in nt/emacs.rc Date: Wed, 26 Nov 2014 00:02:35 +0800 Message-ID: <20141126.000235.1503813762124971108.chriszheng99@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1416931469 15281 80.91.229.3 (25 Nov 2014 16:04:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2014 16:04:29 +0000 (UTC) To: 19179@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 25 17:04:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XtIbE-0006z2-OP for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2014 17:04:21 +0100 Original-Received: from localhost ([::1]:58173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIbE-0004X2-9r for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2014 11:04:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIb5-0004Oh-17 for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:04:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtIaw-0003jG-Vf for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:04:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIaw-0003jA-SD for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XtIaw-0007Xd-MQ for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chris Zheng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Nov 2014 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141693141928956 (code B ref -1); Tue, 25 Nov 2014 16:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Nov 2014 16:03:39 +0000 Original-Received: from localhost ([127.0.0.1]:45117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtIaY-0007Ww-SM for submit@debbugs.gnu.org; Tue, 25 Nov 2014 11:03:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56351) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtIaW-0007Wn-5A for submit@debbugs.gnu.org; Tue, 25 Nov 2014 11:03:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtIaM-0003aG-03 for submit@debbugs.gnu.org; Tue, 25 Nov 2014 11:03:35 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIaL-0003aC-St for submit@debbugs.gnu.org; Tue, 25 Nov 2014 11:03:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIaG-0004FV-2s for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:03:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtIaA-0003Vu-Dj for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:03:20 -0500 Original-Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:54787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtIaA-0003Vb-6L for bug-gnu-emacs@gnu.org; Tue, 25 Nov 2014 11:03:14 -0500 Original-Received: by mail-pa0-f46.google.com with SMTP id lj1so843341pab.5 for ; Tue, 25 Nov 2014 08:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:subject:from:mime-version:content-type :content-transfer-encoding; bh=c9tlvymjteP5pApUeDfIsQpWwF1wozqYTjIjKhGNPd0=; b=aqYGkTsFarjQQYdpS3Pl8dKgMYwB+JLKPoNA6Kcjc8Oe2OoTNP9NFEI+gEVLa6sGqn ngej9UnmtlW9c+VWJFeWcBUNwV9U3VHEzXc1GhGkprmdbH0ltuOSUIhztMWSH9b/9srZ FQHltRFCZOwaNN0WQ9U28YdrK7rbXQFVzeZ6qPgJz3drcegyy9Kw44Gn9a9/05MlvHGd T6xEyrzIDompqH9hDUwSi7nQltMqCyQ5a3hVwT5TAPg6l1dei/IJhn2UuMnc5bivsSBH Oj9GxRgGPwRwyRrPFiS0aj1gOnUJ+ofV26m40Az5a++GXM1drQLhYHLBw5WrOEFLD6zH KihQ== X-Received: by 10.70.54.161 with SMTP id k1mr37332234pdp.110.1416931392333; Tue, 25 Nov 2014 08:03:12 -0800 (PST) Original-Received: from localhost ([112.224.69.246]) by mx.google.com with ESMTPSA id xd3sm1873614pbc.54.2014.11.25.08.03.09 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 25 Nov 2014 08:03:11 -0800 (PST) X-Mailer: Mew version 6.6 on Emacs 25.0.50 / Mule 6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96552 Archived-At: With MSYS2/Mingw-w64 combination, compiling the master (HEAD 88871ef) fails with: windres -I . -O coff -o emacs.res emacs.rc C:\msys64\mingw64\bin\windres.exe: emacs.rc:14: syntax error Makefile:230: recipe for target 'emacs.res' failed make[2]: *** [emacs.res] Error 1 make[2]: Leaving directory '/home/Kel/repo/emacs/nt' It seems that `emacs.rc' goes wrong, since the line 14 looks like: FILEVERSION ,0,0 but it is expected to be: FILEVERSION 25,0,50,0 I think the problem comes from line 1917 in configure.ac, where `$version' is null. Although I know little about the configure, I suspect changing `$version' to `$PACKAGE_VERSION' is OK. That is, the below patch. Am I wrong? I'm eager to know the solution. Thank you. ___ Modified configure.ac diff --git a/configure.ac b/configure.ac index 6b6b1c7..0d12f85 100644 --- a/configure.ac +++ b/configure.ac @@ -1914,7 +1914,7 @@ if test "${HAVE_W32}" = "yes"; then *) EMACS_MANIFEST="emacs-x86.manifest" ;; esac dnl Construct something of the form "24,4,0,0" with 4 components. - comma_version=`echo "$version.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'` + comma_version=`echo "$PACKAGE_VERSION.0.0" | sed -e 's/\./,/g' -e 's/^\([[^,]]*,[[^,]]*,[[^,]]*,[[^,]]*\).*/\1/'` comma_space_version=`echo "$comma_version" | sed 's/,/, /g'` AC_SUBST(comma_version)