Re: Non-ASCII chars in quail rules

["Perry E. Metzger" <perry@piermont.com>]

On Tue, 02 Sep 2014 22:23:54 -0400 Stefan Monnier
<monnier@IRO.UMontreal.CA> wrote:
> But that's expected because of the restriction documented in the
> docstring of input-method-function:
> 
>    It's called with one argument, a printing character that was
> just read. (That means a character with code 040...0176.)
> 
> The patch below lifts this restriction, after which your code seems
> to work.

Indeed, that is doubtless the problem! Thank you!

One note: CHARACTERP does a bit more than is actually needed here, it
may be sufficient to say XINT (c) <= MAX_CHAR or to use the
CHAR_VALID_P macro.

I am not sure what the intent here of the restriction was, but a more
general solution for the entire line of the test might be
CHAR_PRINTABLE_P depending on what that intent actually is. (I don't
entirely understand the intent, so I can't say.)

Perry

> 
> 
>         Stefan
> 
> 
> === modified file 'src/keyboard.c'
> --- src/keyboard.c	2014-08-27 10:51:21 +0000
> +++ src/keyboard.c	2014-09-03 02:20:07 +0000
> @@ -3048,7 +3048,7 @@
>       save the echo area contents for it to refer to.  */
>    if (INTEGERP (c)
>        && ! NILP (Vinput_method_function)
> -      && ' ' <= XINT (c) && XINT (c) < 256 && XINT (c) != 127)
> +      && ' ' <= XINT (c) && CHARACTERP (c) && XINT (c) != 127)
>      {
>        previous_echo_area_message = Fcurrent_message ();
>        Vinput_method_previous_message = previous_echo_area_message;
> @@ -3078,7 +3078,7 @@
>        /* Don't run the input method within a key sequence,
>  	 after the first event of the key sequence.  */
>        && NILP (prev_event)
> -      && ' ' <= XINT (c) && XINT (c) < 256 && XINT (c) != 127)
> +      && ' ' <= XINT (c) && CHARACTERP (c) && XINT (c) != 127)
>      {
>        Lisp_Object keys;
>        ptrdiff_t key_count;
> 



-- 
Perry E. Metzger		perry@piermont.com