all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: esr@thyrsus.com (Eric S. Raymond)
To: emacs-devel@gnu.org
Subject: smerge autolaunch integration for conflicts in git
Date: Wed, 13 Aug 2014 05:13:10 -0400 (EDT)	[thread overview]
Message-ID: <20140813091310.A2525380604@snark.thyrsus.com> (raw)

I had a look at Rüdiger Sonderfeld's patch partially implementing
smerge launching for conflicted files in git.

Good news: Completing the patch was surprisingly easy. Rüdiger's
premises about vc-git's internals seem correct.  The only missing
piece was the resolve command the git backend should use when it
detects that there are no conflict markers remaining, and that is just
"git add" - no dark magic.  I have merged the implementation to trunk.

Bad news: I don't have a practical way to test this change beyond
verifying that the Lisp compiles - it could go pear-shaped when it
sees a live conflict.  Somebody for which this meets a real use case,
like Stefan, will have to try it.

Good news: I merged it anyway because if it breaks, it's not going to
do so seriously and should be easy to fix.  Multiple git adds on a
file are harmless.  The most likely failure is that the regexp for
detecting conflicts in a status listing is slightly off, in which case
the launch hook will simply not fire.

Bad news: I wanted to do this really elegantly, by pulling most of
the smerge launch logic into vc-git.el.  Alas, it's not possible without a
fairly large and disruptive refactoring (which probably shouldn't be
done before 24 release). Before even thinking further in that
direction I want to make sure this patch actually works.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Men trained in arms from their infancy, and animated by the love of liberty,
will afford neither a cheap or easy conquest.
        -- From the Declaration of the Continental Congress, July 1775.



             reply	other threads:[~2014-08-13  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13  9:13 Eric S. Raymond [this message]
2014-08-13 15:07 ` smerge autolaunch integration for conflicts in git Lawrence Mitchell
2014-08-20 20:46 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813091310.A2525380604@snark.thyrsus.com \
    --to=esr@thyrsus.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.