From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r116461: Connect electric-indent-mode up with CC Mode. Bug #15478.
Date: Sun, 2 Mar 2014 11:51:18 +0000 [thread overview]
Message-ID: <20140302115118.GA3768@acm.acm> (raw)
In-Reply-To: <jwvzjl9hq4p.fsf-monnier+emacsdiffs@gnu.org>
Hello, Stefan.
On Sat, Mar 01, 2014 at 10:57:34AM -0500, Stefan Monnier wrote:
> >> > The other bit takes over the value of c-electric-indent-mode into CC
> >> > Mode only when it has been set by the user, thus preventing
> >> > electric.el's default overriding CC Mode's.
> >> For that I think it's better to only obey electric-indent-mode if
> >> Emacs>24.3 rather than use the electric-indent-mode-has-been-called crutch.
Using version numbers to check for features is not exactly clean coding.
> > That does not achieve the same effect.
> Can you give a scenario where the result is different?
The default for electric-indent-mode is changed in a future Emacs
version.
> > Please don't do this. I meant literally what I wrote.
> Yes, but I hate this electric-indent-mode-has-been-called crutch, so we
> need a different solution.
> > A better solution would be to provide a less ugly way of checking whether
> > a user has called electric-indent-mode
> A different way would still be ugly, because this requirement is itself
> ugly. We need to find a solution that does not depend on *how* we got
> to this state.
By "this state" you mean what? The minor mode electric-indent-mode can
be in any of three states: (i) left at its default, (ii) set (or toggled)
to t, (iii) set (or toggled) to nil.
The challenge is to distinguish between (i) and ((ii) or (iii)).
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2014-03-02 11:51 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WFSpO-0001e7-Gm@vcs.savannah.gnu.org>
2014-02-18 0:11 ` [Emacs-diffs] trunk r116461: Connect electric-indent-mode up with CC Mode. Bug #15478 Stefan Monnier
2014-02-22 18:27 ` Alan Mackenzie
2014-02-25 3:24 ` Stefan Monnier
2014-02-28 19:50 ` Alan Mackenzie
2014-03-01 15:57 ` Stefan Monnier
2014-03-02 11:51 ` Alan Mackenzie [this message]
2014-03-04 3:48 ` Stefan Monnier
2014-03-08 22:58 ` Alan Mackenzie
2014-03-09 1:57 ` Stefan Monnier
2014-03-09 12:37 ` Alan Mackenzie
2014-03-10 3:37 ` Stefan Monnier
2014-03-10 6:59 ` Glenn Morris
2014-03-10 12:24 ` João Távora
2014-03-10 18:30 ` Stefan Monnier
2014-03-16 22:35 ` Alan Mackenzie
2014-03-17 15:48 ` Stefan
2014-03-19 22:42 ` Alan Mackenzie
2014-03-20 1:46 ` Stefan
2014-03-20 8:35 ` Thien-Thi Nguyen
2014-03-21 8:24 ` João Távora
2014-03-22 13:13 ` Alan Mackenzie
2014-03-22 16:14 ` Stefan
2014-03-22 20:19 ` David Caldwell
2014-03-22 22:05 ` David Kastrup
2014-03-22 22:32 ` David Caldwell
2014-03-24 1:13 ` Stefan
2014-03-22 22:34 ` Alan Mackenzie
2014-03-24 1:37 ` Stefan
2014-03-24 22:40 ` Alan Mackenzie
2014-03-25 1:37 ` Dmitry Gutov
2014-03-26 20:53 ` Alan Mackenzie
2014-03-27 8:02 ` Dmitry Gutov
2014-03-30 14:57 ` Alan Mackenzie
2014-03-31 17:11 ` Dmitry Gutov
2014-04-03 21:53 ` Alan Mackenzie
2014-03-25 1:54 ` Stefan
2014-03-26 21:21 ` Alan Mackenzie
2014-03-27 14:49 ` Stefan Monnier
2014-03-30 11:37 ` Alan Mackenzie
2014-03-30 16:46 ` Stefan Monnier
2014-03-22 23:10 ` Alan Mackenzie
2014-03-24 1:39 ` Stefan
2014-03-24 6:59 ` Stephen J. Turnbull
2014-03-24 9:08 ` Dmitry Gutov
2014-03-24 17:19 ` Eli Zaretskii
2014-03-24 17:29 ` David Kastrup
2014-03-24 17:39 ` David Kastrup
2014-03-24 17:38 ` Dmitry Gutov
2014-03-24 17:52 ` Eli Zaretskii
2014-03-25 1:53 ` Dmitry Gutov
2014-03-25 3:49 ` Eli Zaretskii
2014-03-24 18:32 ` Stefan
2014-03-25 1:49 ` Dmitry Gutov
2014-03-25 7:44 ` Stephen J. Turnbull
2014-03-25 8:08 ` Steinar Bang
2014-03-25 16:49 ` Stephen J. Turnbull
2014-03-25 17:08 ` Steinar Bang
2014-03-25 17:31 ` Dmitry Gutov
2014-03-25 19:28 ` Steinar Bang
2014-03-25 19:49 ` David Kastrup
2014-03-25 19:54 ` Dmitry Gutov
2014-03-25 13:26 ` Stefan Monnier
2014-03-27 7:51 ` Stephen J. Turnbull
2014-03-24 21:12 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140302115118.GA3768@acm.acm \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.