From: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>
To: Agustin Martin <agustin.martin@hispalinux.es>
Cc: 16800@debbugs.gnu.org
Subject: bug#16800: 24.3; flyspell works slow on very short words at the end of big file
Date: Sun, 23 Feb 2014 23:56:59 +0400 [thread overview]
Message-ID: <20140223195659.GA23581@openwall.com> (raw)
In-Reply-To: <CAKy3oZrSb25AdubsLqQt=5iWZiqN2caJvwWZSozeZLd-tH8hGg@mail.gmail.com>
On Sun, Feb 23, 2014 at 02:26:00AM +0100, Agustin Martin wrote:
> 2014-02-22 22:03 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>
> > > Date: Sat, 22 Feb 2014 22:55:11 +0400
> > > From: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>
> > >
> > > > > Emacs words are language sensitive too.
> > > >
> > > > But not in the same way as ispell/flyspell is. The CASECHARS,
> > > > NON-CASECHARS, and OTHERCHARS parameters of the dictionary are only
> > > > taken into account by ispell/flyspell.
> > >
> > > I think one could define a dictionary like: ("my" "[a]" "[^a]" "" ...)
> > > So the only letter for flyspell words is "a". That way "qqaaqqaaqq" is
> > > one word for emacs and two words with garbage around for flyspell. I
> > > think my solution fails in such case.
> >
> > It's more complex than that: with some languages, and at least with
> > aspell, we take these parameters from the dictionary. So they cannot
> > be known in advance in some cases.
> >
>
> Hi,
>
> Not yet sure if I am missing something important, but I am playing with a
> regexp search in flyspell-word-search-* functions based on what flyspell
> thinks is the word to spellcheck (`word') and what thinks should not be
> part of a word (`NOTCASECHARS'). Since no OTHERCHARS is used there may be
> some intermediate matches being false positives that will be discarded once
> flyspell-word checks them.
>
> I have tested this in Alekseys's file and is apparently working well and in
> this particular case with much better efficiency. Need to think about more
> ad-hoc situations where it may fail or slow down things. Suggestions for
> possible failures are welcome.
>
> Patch is attached. I did the tests against an old and patched version of
> flyspell.el (that shipped with Debian stable) and built the patch for it.
> Should apply and work similarly in trunk's flyspell.el.
>
> --- flyspell.el.orig 2014-02-23 02:17:03.680107519 +0100
> +++ flyspell.el 2014-02-23 02:50:50.634625248 +0100
> @@ -1050,8 +1050,19 @@
> (save-excursion
> (let ((r '())
> (inhibit-point-motion-hooks t)
> + (flyspell-not-casechars (flyspell-get-not-casechars))
I'd move concat here too so it is out of inner loop.
> p)
> - (while (and (not r) (setq p (search-backward word bound t)))
> + (while
> + (and (not r)
> + (setq p
> + (re-search-backward
> + (concat
> + "\\(" flyspell-not-casechars "\\|\\b\\)"
I think \b here could be replaced with \` (beginning of buffer). I
think it is the only boundary we need that is not described by
not-casechars, word sequence. Similarly \' (end of buffer) could be
used for forward search.
Also not capturing group ("\\(?:") could be used because we do not
need a match data of the first group. It should work faster but I
don't really know.
Maybe it would be faster to not capture word but capture one char or
void but I doubt the difference would be noticable.
> + "\\(" word "\\)"
I think regexp-quote around the word is necessary here.
> + flyspell-not-casechars
> + )
> + bound t)))
> + (goto-char (match-beginning 2))
s/2/1/ if the first group is not capturing.
> (let ((lw (flyspell-get-word)))
> (if (and (consp lw)
> (if ignore-case
> @@ -1068,8 +1079,19 @@
> (save-excursion
> (let ((r '())
> (inhibit-point-motion-hooks t)
> + (flyspell-not-casechars (flyspell-get-not-casechars))
concat here as above.
> p)
> - (while (and (not r) (setq p (search-forward word bound t)))
> + (while
> + (and (not r)
> + (setq p
> + (re-search-forward
> + (concat
> + flyspell-not-casechars
> + "\\(" word "\\)"
regexp-quote as above.
> + "\\(" flyspell-not-casechars "\\|\\b\\)"
I think \b could be replaced by \' here as described above.
The second group could be not capturing here.
> + )
> + bound t)))
> + (goto-char (match-beginning 1))
I guess match-end should here.
> (let ((lw (flyspell-get-word)))
> (if (and (consp lw) (string-equal (car lw) word))
> (setq r p)
I guess that \b would work faster than the group so we could have 'if'
statement around the whole loop that has one implementation with \b
for case when casechars are "[[:alpha:]]" and not-casechars are
"[^[:alpha:]]" and another implementation as above for other cases.
But it seems cumbersome.
Thanks!
--
Regards,
Aleksey Cherepanov
next prev parent reply other threads:[~2014-02-23 19:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 20:56 bug#16800: 24.3; flyspell works slow on very short words at the end of big file Aleksey Cherepanov
2014-02-21 10:15 ` Eli Zaretskii
2014-02-21 14:38 ` Agustin Martin
2014-02-21 15:12 ` Eli Zaretskii
2014-02-21 15:21 ` Eli Zaretskii
2014-02-22 12:44 ` Aleksey Cherepanov
2014-02-22 13:10 ` Eli Zaretskii
2014-02-22 16:02 ` Aleksey Cherepanov
2014-02-22 16:41 ` Eli Zaretskii
2014-02-22 18:55 ` Aleksey Cherepanov
2014-02-22 20:16 ` Aleksey Cherepanov
2014-02-22 21:03 ` Eli Zaretskii
2014-02-23 1:26 ` Agustin Martin
2014-02-23 18:36 ` Eli Zaretskii
2014-02-23 19:56 ` Aleksey Cherepanov [this message]
2014-02-23 23:02 ` Aleksey Cherepanov
2014-02-24 16:03 ` Aleksey Cherepanov
2014-02-26 20:32 ` Agustin Martin
2014-02-28 11:45 ` Agustin Martin
2014-02-28 11:51 ` Eli Zaretskii
2014-03-01 21:44 ` Aleksey Cherepanov
2014-03-02 3:56 ` Eli Zaretskii
2014-03-09 17:36 ` Agustin Martin
2014-03-09 18:02 ` Aleksey Cherepanov
2014-03-09 18:24 ` Eli Zaretskii
2014-02-28 23:11 ` Aleksey Cherepanov
2014-03-01 10:33 ` Aleksey Cherepanov
2014-03-01 15:50 ` Aleksey Cherepanov
2014-03-01 21:39 ` Aleksey Cherepanov
2014-03-09 17:25 ` Agustin Martin
2015-03-06 21:46 ` Agustin Martin
2015-03-07 8:09 ` Eli Zaretskii
2014-02-23 20:39 ` Aleksey Cherepanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223195659.GA23581@openwall.com \
--to=aleksey.4erepanov@gmail.com \
--cc=16800@debbugs.gnu.org \
--cc=agustin.martin@hispalinux.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.