Fossil references in the Emacs tree - request for review

Fossil references in the Emacs tree - request for review

[Eric S. Raymond]

I believe I have identified all the Bazaar and CVS revision references in
Emacs head.  My intention is to patch these to action stamps on
conversion day.

ChangeLog:
	revno 108687
admin/ChangeLog:
	revno:105007
etc/ChangeLog:
	r112148
	revno:108936
	revision 106831
	CVS-1.61
	1.61 in CVS
lib-src/ChangeLog:
	revno:106608
	revno 100789
lisp/ChangeLog:
	rev. 110325
	r115470
	of 2012-12-20 (r111276)
	2013-12-11 (r115470)
	revno:114543
	revno:113793
	revno:113117
	r114834
	revno:113431
	revno:113147
masdos/ChangeLog
	revno 101897
	revno 101876
	revno 100306
nt/ChangeLog:
	revno 108687
src/ChangeLog:
	revision 114614 (commit of 2013-10-10)
	revno:113431
doc/lispref/ChangeLog:
	revno 101949

Because ChangeLog entries cumulate rather than being revised I am
pretty sure this set is exhaustive for the entire history of the
ChangeLogs.

I checked the entire rest of the tree for revisions in these forms.
I also looked for bare CVS revision numbers of the form 1.[0-9]+ but
found none of those.

It's easy to miss matches in the clutter, so I made several passes with
different noise filters.  Still, it is possible I missed a few.  It
would be a good thing if someone independently checked my work.

(This report does not include revision comments.  That's another and
larger kettle of fish.)
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

If a thousand men were not to pay their tax-bills this year, that would
... [be] the definition of a peaceable revolution, if any such is possible.
	-- Henry David Thoreau

Re: Fossil references in the Emacs tree - request for review

[Eli Zaretskii]

> From: esr@thyrsus.com (Eric S. Raymond)
> Date: Wed, 15 Jan 2014 14:59:42 -0500 (EST)
> 
> I believe I have identified all the Bazaar and CVS revision references in
> Emacs head.

Not sure what that means: are you talking only about references in
ChangeLog files?  I thought the references in the commit messages were
also of interest.

But even if only ChangeLog files are to be included, I see, for
example, this:

  ./src/ChangeLog.12:15350:       2011-08-30 (revision 105619).  (Bug#9530)
  ./src/ChangeLog.12:15460:       2011-08-30 (revision 105619).  (Bug#9475)
  ./src/ChangeLog.12:16924:       revision 84777 on 2008-02-22.
  ./src/ChangeLog.12:19655:       revision 104625).
  ./src/ChangeLog.12:19835:       revision 104134).

Did you forget (or omitted on purpose) ChangeLog.* files?

Re: Fossil references in the Emacs tree - request for review

[Eric S. Raymond]

Eli Zaretskii <eliz@gnu.org>:
> Did you forget (or omitted on purpose) ChangeLog.* files?

Yoicks!  Forgotten.  I'll add those to the list.

It's an interesting question why my whole-tree grep didn't find those.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Re: Fossil references in the Emacs tree - request for review

[Glenn Morris]

Eric S. Raymond wrote:

> I believe I have identified all the Bazaar and CVS revision references in
> Emacs head.  My intention is to patch these to action stamps on
> conversion day.

Part of the point of ChangeLogs is that they are supposed to be usable
without the VCS, so IMO these references to revisions should never have
been there, and should just be replaced with the appropriate date.

Eg as it stands:

   * register.el (insert-register): Fix revno:114543.

is meaningless for a ChangeLog. "Fix 2013-10-07 change" seems fine to
me; I doubt anything more is needed. (I assume the VCS log will still
contain the specific commit reference.)

Re: Fossil references in the Emacs tree - request for review

[Eric S. Raymond]

Glenn Morris <rgm@gnu.org>:
> Part of the point of ChangeLogs is that they are supposed to be usable
> without the VCS, so IMO these references to revisions should never have
> been there, and should just be replaced with the appropriate date.
> 
> Eg as it stands:
> 
>    * register.el (insert-register): Fix revno:114543.
> 
> is meaningless for a ChangeLog. "Fix 2013-10-07 change" seems fine to
> me; I doubt anything more is needed. (I assume the VCS log will still
> contain the specific commit reference.)

It will.  I'll take care of this.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>