all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: esr@thyrsus.com (Eric S. Raymond)
To: emacs-devel@gnu.org
Subject: Witness computation - minor breakage in the build system
Date: Sat, 11 Jan 2014 23:37:35 -0500 (EST)	[thread overview]
Message-ID: <20140112043735.C0A2E380523@snark.thyrsus.com> (raw)

Is any particular person responsible for the build system?

While working on one of my to-do items I found an apparent bug
in Makefile.in.  The src production tries to compute the location 
of a "witness" file with modtime taken as the time of most recent
repository change.

The computation is wrong, however, and fails - leaving VCSWITNESS 
empty.  This has escaped notice because the effect is subtle: 
re-dumping may not always be forced when it should be after a
repository update.  To see that this true, add code just before
the make invocation on line 384 to dump $vcswitness.  Don't forget
to double the $.

I stumbled over this because part of my transition plan is to get
the code to a state where it can do a full build (with proper revision
ID amd conditional dumping) regardless of whether the underlying 
repo is Bazaar or Git.

I could patch-fix this.  But I think the fixed Makefile code would
remain unpleasantly fragile, and the witness-path computation is
best moved to the configure stage.

Comments? Objections? Is anyone else willing to take respomsibility
for this?
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is
a well-armed lamb contesting the vote!
	-- Benjamin Franklin



             reply	other threads:[~2014-01-12  4:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12  4:37 Eric S. Raymond [this message]
2014-01-12  4:50 ` Witness computation - minor breakage in the build system Paul Eggert
2014-01-12  5:08   ` Eric S. Raymond
2014-01-12 14:52     ` Stefan Monnier
2014-01-12 14:57       ` Eric S. Raymond
2014-01-12 19:36         ` Stefan Monnier
2014-01-12 19:45           ` David Kastrup
2014-01-12 19:53             ` Andreas Schwab
2014-01-12 20:07               ` David Kastrup
2014-01-12 15:57     ` Eli Zaretskii
2014-01-12 14:51   ` Stefan Monnier
2014-01-12 15:56   ` Eli Zaretskii
2014-01-12 19:22     ` Paul Eggert
2014-01-12 19:43       ` Eric S. Raymond
2014-01-12 22:29         ` Stefan Monnier
2014-01-12 22:51           ` Paul Eggert
2014-01-13  3:14             ` Stefan Monnier
2014-01-13  3:44               ` Paul Eggert
2014-01-13  4:16                 ` Stefan Monnier
2014-01-13  6:27                   ` Paul Eggert
2014-01-13 14:06                     ` Stefan Monnier
2014-01-12 21:01       ` Eli Zaretskii
2014-01-12 19:15   ` Glenn Morris
2014-01-13  3:16 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140112043735.C0A2E380523@snark.thyrsus.com \
    --to=esr@thyrsus.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.