From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 10:08:51 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20140109150851.GA7194@thyrsus.com> References: <20140109052705.GA3424@thyrsus.com> <20140109123702.GB5361@thyrsus.com> <20140109131337.GA6053@thyrsus.com> <20140109134716.GA6290@thyrsus.com> <20140109142956.GA6731@thyrsus.com> Reply-To: esr@thyrsus.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1389280180 3613 80.91.229.3 (9 Jan 2014 15:09:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 15:09:40 +0000 (UTC) Cc: Bastien , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 16:09:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1HEr-00067z-4u for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 16:09:42 +0100 Original-Received: from localhost ([::1]:52501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1HEq-00087r-KP for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 10:09:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1HEj-00087L-Nk for emacs-devel@gnu.org; Thu, 09 Jan 2014 10:09:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1HEe-0003DM-2P for emacs-devel@gnu.org; Thu, 09 Jan 2014 10:09:33 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:38456 helo=snark.thyrsus.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1HEY-0003Ab-BS; Thu, 09 Jan 2014 10:09:22 -0500 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id 95E47380F35; Thu, 9 Jan 2014 10:08:51 -0500 (EST) Content-Disposition: inline In-Reply-To: X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 71.162.243.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167920 Archived-At: Juanma Barranquero : > On Thu, Jan 9, 2014 at 3:29 PM, Eric S. Raymond wrote: > > > By your own analysis, there is *no* compatible fix. Whatever the function > > and variable are called, stuff is going to break because the revision-ID > > format is different. > > It won't be able to extract the required information, because it will > not exist anymore. But, as that code is checking for nil, it won't > break. Your change will make it break: > > (setq emacs-repository-version "fce2a09142ddccc242931edd16712c2c24e10e8e") > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p > fce2a09142ddccc242931edd16712c2c24e10e8e) > -(115933 fce2a09142ddccc242931edd16712c2c24e10e8e) > (and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version) (- > (read (emacs-bzr-get-version)) (read emacs-bzr-version))) > eval((and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version) > (- (read (emacs-bzr-get-version)) (read emacs-bzr-version))) nil) > eval-last-sexp-1(nil) > eval-last-sexp(nil) > call-interactively(eval-last-sexp nil nil) > command-execute(eval-last-sexp) That's before putting the function alias in place, right? I'm going to push a change to fix that. The only reason I haven't already is that I have another change waiting > But anyway, that's not even the issue. The issue is that we had an > interface which said that it would return a string with some format, > or nil. That is correct. > You want to keep that interface, but make it return something > different. That's incompatible *and* unnecessary. That is incorrect. emacs-bzr-get-version will return *exactly the name thing* as it did before the change, *under all circumstances*. That's the point of the alias. Are you telling me the alias geature doesn't work? If so, we have larger problems... > And you seem to > insist just because you don't like the idea of the old APIs being > around in loadup.el? That's right. The old API was misdesigned; it leaked information that it should not. Since that can be fixed in a compatible way, it should be. -- Eric S. Raymond