From: "Eric S. Raymond" <esr@thyrsus.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Bastien <bzg@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 10:08:51 -0500 [thread overview]
Message-ID: <20140109150851.GA7194@thyrsus.com> (raw)
In-Reply-To: <CAAeL0SR-iQGQb1F7=8gRBkNQMcSbabGFuLn0xf421nKwXVcaVw@mail.gmail.com>
Juanma Barranquero <lekktu@gmail.com>:
> On Thu, Jan 9, 2014 at 3:29 PM, Eric S. Raymond <esr@thyrsus.com> wrote:
>
> > By your own analysis, there is *no* compatible fix. Whatever the function
> > and variable are called, stuff is going to break because the revision-ID
> > format is different.
>
> It won't be able to extract the required information, because it will
> not exist anymore. But, as that code is checking for nil, it won't
> break. Your change will make it break:
>
> (setq emacs-repository-version "fce2a09142ddccc242931edd16712c2c24e10e8e")
>
> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p
> fce2a09142ddccc242931edd16712c2c24e10e8e)
> -(115933 fce2a09142ddccc242931edd16712c2c24e10e8e)
> (and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version) (-
> (read (emacs-bzr-get-version)) (read emacs-bzr-version)))
> eval((and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version)
> (- (read (emacs-bzr-get-version)) (read emacs-bzr-version))) nil)
> eval-last-sexp-1(nil)
> eval-last-sexp(nil)
> call-interactively(eval-last-sexp nil nil)
> command-execute(eval-last-sexp)
That's before putting the function alias in place, right? I'm going to push
a change to fix that. The only reason I haven't already is that I have
another change waiting
> But anyway, that's not even the issue. The issue is that we had an
> interface which said that it would return a string with some format,
> or nil.
That is correct.
> You want to keep that interface, but make it return something
> different. That's incompatible *and* unnecessary.
That is incorrect. emacs-bzr-get-version will return *exactly the name thing*
as it did before the change, *under all circumstances*. That's the point
of the alias. Are you telling me the alias geature doesn't work? If so,
we have larger problems...
> And you seem to
> insist just because you don't like the idea of the old APIs being
> around in loadup.el?
That's right. The old API was misdesigned; it leaked information that
it should not. Since that can be fixed in a compatible way, it should be.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2014-01-09 15:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W124t-0007MM-P3@vcs.savannah.gnu.org>
2014-01-08 23:18 ` trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names Glenn Morris
2014-01-08 23:34 ` Eric S. Raymond
2014-01-08 23:57 ` Juanma Barranquero
2014-01-09 0:04 ` Eric S. Raymond
2014-01-09 0:06 ` Daniel Colascione
2014-01-09 0:12 ` Eric S. Raymond
2014-01-09 0:13 ` Daniel Colascione
2014-01-09 0:09 ` Bastien
2014-01-09 0:27 ` Eric S. Raymond
2014-01-09 0:43 ` Juanma Barranquero
2014-01-09 1:25 ` Eric S. Raymond
2014-01-09 1:31 ` Juanma Barranquero
2014-01-09 2:13 ` Juanma Barranquero
2014-01-09 5:27 ` Eric S. Raymond
2014-01-09 9:36 ` Juanma Barranquero
2014-01-09 12:37 ` Eric S. Raymond
2014-01-09 12:48 ` Juanma Barranquero
2014-01-09 13:13 ` Eric S. Raymond
2014-01-09 13:27 ` Juanma Barranquero
2014-01-09 13:47 ` Eric S. Raymond
2014-01-09 14:05 ` Juanma Barranquero
2014-01-09 14:29 ` Eric S. Raymond
2014-01-09 14:45 ` Juanma Barranquero
2014-01-09 15:08 ` Eric S. Raymond [this message]
2014-01-09 15:21 ` Juanma Barranquero
2014-01-09 20:43 ` chad
2014-01-09 12:00 ` Rüdiger Sonderfeld
2014-01-09 12:12 ` Juanma Barranquero
2014-01-09 12:20 ` Rüdiger Sonderfeld
2014-01-09 12:24 ` Juanma Barranquero
2014-01-09 0:10 ` Juanma Barranquero
2014-01-09 3:48 ` Stephen J. Turnbull
2014-01-09 0:34 ` Glenn Morris
2014-01-09 6:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109150851.GA7194@thyrsus.com \
--to=esr@thyrsus.com \
--cc=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.