From: "Eric S. Raymond" <esr@thyrsus.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Bastien <bzg@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 07:37:02 -0500 [thread overview]
Message-ID: <20140109123702.GB5361@thyrsus.com> (raw)
In-Reply-To: <CAAeL0SSR92C+dn1mW8N9K-BeqPEW62CQ6rRiSzW339LApNvd8g@mail.gmail.com>
Juanma Barranquero <lekktu@gmail.com>:
> So, to summarize, I think the right thing to do is:
>
> 1.- Restore emacs-bzr(-get)-version, with docstring and all.
> 2.- (Keep, if you want, your new and currently useless
> emacs-revision(-get)-version API)
> 3.- Just after the switch, make obsolete the old pair with
>
> (make-obsolete 'emacs-bzr-get-version 'emacs-repository-get-version "24.4")
> (make-obsolete-variable 'emacs-bzr-version 'emacs-repository-version "24.4")
I must be missing something. I don't see how this would solve any problem
at all.
I don't understand why simply looking at emacs-bzr-version isn't working
for you, given that it's now aliased.
What would (emacs-bug) look at under this plan? If your answer is
emacs-bzr-version, I strongly object. The fact that the VCS name
was exposed at that level was a *bug*, a layering violation (and I would
say the same thing if the name had been emacs-git-version). Nothing
in Lisp outside version.el has need to know that and therefore
should not know it.
You're going to have a flag day either way when the VCS changes; I
don't get why pushing it into the future by deferring the rename would
help you.
I don't see any win at all in this reversion. And because doing it would
reintroduce a layering violation, I'm going to need a lot of convincing.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2014-01-09 12:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W124t-0007MM-P3@vcs.savannah.gnu.org>
2014-01-08 23:18 ` trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names Glenn Morris
2014-01-08 23:34 ` Eric S. Raymond
2014-01-08 23:57 ` Juanma Barranquero
2014-01-09 0:04 ` Eric S. Raymond
2014-01-09 0:06 ` Daniel Colascione
2014-01-09 0:12 ` Eric S. Raymond
2014-01-09 0:13 ` Daniel Colascione
2014-01-09 0:09 ` Bastien
2014-01-09 0:27 ` Eric S. Raymond
2014-01-09 0:43 ` Juanma Barranquero
2014-01-09 1:25 ` Eric S. Raymond
2014-01-09 1:31 ` Juanma Barranquero
2014-01-09 2:13 ` Juanma Barranquero
2014-01-09 5:27 ` Eric S. Raymond
2014-01-09 9:36 ` Juanma Barranquero
2014-01-09 12:37 ` Eric S. Raymond [this message]
2014-01-09 12:48 ` Juanma Barranquero
2014-01-09 13:13 ` Eric S. Raymond
2014-01-09 13:27 ` Juanma Barranquero
2014-01-09 13:47 ` Eric S. Raymond
2014-01-09 14:05 ` Juanma Barranquero
2014-01-09 14:29 ` Eric S. Raymond
2014-01-09 14:45 ` Juanma Barranquero
2014-01-09 15:08 ` Eric S. Raymond
2014-01-09 15:21 ` Juanma Barranquero
2014-01-09 20:43 ` chad
2014-01-09 12:00 ` Rüdiger Sonderfeld
2014-01-09 12:12 ` Juanma Barranquero
2014-01-09 12:20 ` Rüdiger Sonderfeld
2014-01-09 12:24 ` Juanma Barranquero
2014-01-09 0:10 ` Juanma Barranquero
2014-01-09 3:48 ` Stephen J. Turnbull
2014-01-09 0:34 ` Glenn Morris
2014-01-09 6:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109123702.GB5361@thyrsus.com \
--to=esr@thyrsus.com \
--cc=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.