From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 00:27:05 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20140109052705.GA3424@thyrsus.com> References: <56y52qcbbh.fsf@fencepost.gnu.org> <20140108233424.GA15258@thyrsus.com> <20140109000406.GA22775@thyrsus.com> <87mwj6f23d.fsf@bzg.ath.cx> <20140109002754.GA22950@thyrsus.com> <20140109012554.GA23333@thyrsus.com> Reply-To: esr@thyrsus.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1389245267 27698 80.91.229.3 (9 Jan 2014 05:27:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 05:27:47 +0000 (UTC) Cc: Bastien , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 06:27:54 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W189p-0002rv-Jr for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 06:27:53 +0100 Original-Received: from localhost ([::1]:50143 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W189p-0001cZ-5x for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 00:27:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W189i-0001cU-R3 for emacs-devel@gnu.org; Thu, 09 Jan 2014 00:27:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W189e-0005op-3X for emacs-devel@gnu.org; Thu, 09 Jan 2014 00:27:46 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:36146 helo=snark.thyrsus.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W189Y-0005nh-Ot; Thu, 09 Jan 2014 00:27:36 -0500 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id 16F4C3805F2; Thu, 9 Jan 2014 00:27:06 -0500 (EST) Content-Disposition: inline In-Reply-To: X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 71.162.243.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167853 Archived-At: Juanma Barranquero : > On second thought, I'm not so sure that renaming emacs-bzr-version and > emacs-bzr-get-version is a good idea > > The reason is that emacs-repository-version and > emacs-repository-get-version won't be true replacements for the > current variable and function. They won't contain or return data in > the same format, and I won't be able, for example, to just use > emacs-repository-version in the same way I'm using emacs-bzr-version > right now. That's true, but it has nothing to do with how the function and vaeriable are named and cannot be fixed by changing the name back or twinning the function. If you look at emacs-repository-version, it now returns exactly what you're used to with the bzr local revision number up front. When we change over to git, there won't be a local revision number because there is no such entity in the git universe. This can't be fixed by anything in the way our LISP is named or factored. > It's not possible, because I'm using the fact that their > value started with a numerical revno (I'm doing arithmetic with that > value), which does not make sense in Git. I will be forced to change > my code, so just making emacs-bzr-version into an obsolete alias of > emacs-repository-version is misleading. You're making a good case for removing the obsolete alias. But... > IMO it would make more sense to define new emacs-git-version and > emacs-git-get-version instances and let user code sort which one needs > to use. It might, if we were going to use two VCSes in parallel. That's not the case. Where the rubber meets the road is: What should emacs-bug call to get a build version to report? There can be only one... > These function and variable are never going to be really > repository- or DVCS-independent anyway. The implementation, no. But the behavior "return a unique magic cookie that identifies the build" is DVCS-independent. You're feeling pain because you want the magic cookie to have substructure, and *that* can't be guaranteed across VCSes. But reverting my renames wouldn't solve that problem either. -- Eric S. Raymond