From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: electric-indent-mode: abolition of `newline' function is not the Right Thing.
Date: Sun, 13 Oct 2013 17:28:41 +0000 [thread overview]
Message-ID: <20131013172841.GA2498@acm.acm> (raw)
In-Reply-To: <jwvvc11p4po.fsf-monnier+emacs@gnu.org>
Hello, Stefan.
On Sun, Oct 13, 2013 at 12:22:33PM -0400, Stefan Monnier wrote:
> > :-) Of course there are workarounds, but that's not the point.
> > There are approximately 198 calls to `newline' in the Emacs Lisp
> > sources, and an unknown further number in other Lisp files and users'
> > .emacsen. Some of these calls are going to get broken by the
> > effective change to `newline'.
> Right. But the problem is that this is not specific to
> electric-indent-mode: newline calls self-insert-command, which runs
> expand-abbrev and (since Emacs24) post-self-insert-hook. Any caller
> which only wants a \n and no extra doo-dads should not call `newline'.
> electric-indent-mode just makes this problem more apparent.
Sorry Stefan, but that is disingenuous. If you look again at
`electric-indent-post-self-insert-function', you will see that that
function deliberately converts `newline' into `newline-and-indent'. It
even says so in the comments. _This_ is the problem.
What is the justification for this extension in functionality of
`newline' to do the same as `newline-and-indent'?
And people calling `newline' do not simply want a \n. They want
abbreviations to be processed, they want auto-fill to be run, trailing
space to be removed from otherwise blank lines, and so on. What they
_don't_ want is indentation inserted on the new line.
Please take this indent-newline functionality out of
e-i-post-s-i-function (or let me do it).
Incidentally, each call of e-i-post-s-i-function creates a new marker,
bound to the let variable `before'. This is not set to point nowhere
before `before' becomes unbound. I think it probably should.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2013-10-13 17:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 10:13 electric-indent-mode: abolition of `newline' function is not the Right Thing Alan Mackenzie
2013-10-13 13:23 ` Stefan Monnier
2013-10-13 14:09 ` Alan Mackenzie
2013-10-13 16:22 ` Stefan Monnier
2013-10-13 17:28 ` Alan Mackenzie [this message]
2013-10-14 12:56 ` Stefan Monnier
2013-10-16 18:46 ` Alan Mackenzie
2013-10-15 18:28 ` martin rudalics
2013-10-16 17:12 ` Alan Mackenzie
2013-10-16 17:59 ` Stefan Monnier
2013-10-16 18:58 ` Alan Mackenzie
2013-10-16 20:55 ` chad
2013-10-16 21:07 ` Daniel Colascione
2013-10-18 16:51 ` Alan Mackenzie
2013-10-16 23:22 ` Stephen J. Turnbull
2013-10-16 18:34 ` martin rudalics
2013-10-16 19:26 ` Default behaviour of RET Alan Mackenzie
2013-10-16 19:47 ` Eli Zaretskii
2013-10-16 23:17 ` Stephen J. Turnbull
2013-10-17 0:47 ` Stefan Monnier
2013-10-18 17:03 ` Alan Mackenzie
2013-10-18 19:52 ` Stefan Monnier
2013-10-18 20:45 ` Alan Mackenzie
2013-10-19 1:59 ` Stefan Monnier
2013-10-19 10:58 ` Alan Mackenzie
2013-10-19 15:07 ` Drew Adams
2013-10-20 14:55 ` Alan Mackenzie
2013-10-20 22:26 ` Richard Stallman
2013-10-21 2:38 ` Eli Zaretskii
2013-10-19 22:20 ` Stefan Monnier
2013-10-20 15:00 ` Alan Mackenzie
2013-10-18 16:57 ` Alan Mackenzie
2013-10-13 20:00 ` electric-indent-mode: abolition of `newline' function is not the Right Thing Matthias Meulien
2013-10-14 13:21 ` Stefan Monnier
2013-10-14 13:31 ` Matthias Meulien
2013-10-14 16:46 ` Stefan Monnier
2013-10-15 15:54 ` Davis Herring
2013-10-15 20:03 ` Matthias Meulien
2013-10-16 2:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131013172841.GA2498@acm.acm \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.