From: Jorgen Schaefer <forcer@forcix.cx>
To: emacs-devel@gnu.org
Subject: minibuffer.el completion bug with markers
Date: Sat, 21 Sep 2013 21:34:21 +0200 [thread overview]
Message-ID: <20130921213421.4e7b91ec@forcix.kollektiv-hamburg.de> (raw)
Hello!
The recent changes to minibuffer.el broke completion functions when
they use markers to define where the completed text starts and ends.
Reproduction:
(with-temp-buffer
(cl-flet ((test/completion-at-point ()
(list (copy-marker (point-min))
(copy-marker (point))
'test/completion-table))
(test/completion-table (string pred action)
(if (eq action 'lambda)
nil
"test: ")))
(let ((completion-at-point-functions '(test/completion-at-point)))
(insert "TEST")
(completion-at-point)
(assert (equal (buffer-string)
"test: ")))))
This errors out in `completion--replace' because the call to
`delete-region' calculates the end point to delete based on (- end
beg), where end can have moved at this point due to the insertion of
text using `insert-and-inherit'. Simple fix:
--- lisp/minibuffer.el 2013-09-16 19:09:24 +0000
+++ lisp/minibuffer.el 2013-09-21 19:26:47 +0000
@@ -873,8 +873,9 @@
(setq end (- end suffix-len))
(setq newtext (substring newtext 0 (- suffix-len))))
(goto-char beg)
- (insert-and-inherit newtext)
- (delete-region (point) (+ (point) (- end beg)))
+ (let ((length (- end beg)))
+ (insert-and-inherit newtext)
+ (delete-region (point) (+ (point) length)))
(forward-char suffix-len)))
(defcustom completion-cycle-threshold nil
Regards,
Jorgen
next reply other threads:[~2013-09-21 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 19:34 Jorgen Schaefer [this message]
2013-10-04 2:24 ` minibuffer.el completion bug with markers Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130921213421.4e7b91ec@forcix.kollektiv-hamburg.de \
--to=forcer@forcix.cx \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.