From: Alan Mackenzie <acm@muc.de>
To: 15207@debbugs.gnu.org, Gauthier ?stervall <gauthier@ostervall.se>
Subject: bug#15207: 24.2; C Highlight colors around CV-modifiers
Date: Sun, 1 Sep 2013 09:10:27 +0000 [thread overview]
Message-ID: <20130901091027.GA2959__4999.61520913548$1378026751$gmane$org@acm.acm> (raw)
In-Reply-To: <CAM8gEgh8PEGPFRQb-AsvXjFjP70dKqWLwa1T8xRgT8dNBaaa1A@mail.gmail.com>
Hi, Gauthier.
Gauthier ?stervall <gauthier@ostervall.se> wrote:
> C highlighting is not consistent depending on the placement of
> CV-modifiers in variable declarations.
> Example:
> const type1 var1;
> type2 const var2;
> Both declarations are equivalent but the color of "type?" differs.
> Issue verified in version 24.3 as well.
Bug #15211 seems to be a duplicate of this bug. It's amazing how a bug
like this can remain undetected for over a decade, then suddenly two
people report it within a few hours of eachother.
Would you please try out the patch from #15211, and let me know whether
it fixes the bug, doesn't quite fix it, or there are unwanted side
effects. Here it is again:
diff -r 45df171f9859 cc-engine.el
--- a/cc-engine.el Sat Aug 31 11:09:30 2013 +0000
+++ b/cc-engine.el Sat Aug 31 20:32:22 2013 +0000
@@ -7440,7 +7440,8 @@
;; interactive refontification.
(c-put-c-type-property (point) 'c-decl-arg-start))
- (when (and c-record-type-identifiers at-type (not (eq at-type t)))
+ (when (and c-record-type-identifiers at-type ;; (not (eq at-type t))
+ )
(let ((c-promote-possible-types t))
(save-excursion
(goto-char type-start)
I'll just repeat what I said in #15211: the code in CC Mode took trouble
to _exclude_ "type2" from being fontified, and I don't understand why.
There may be side effects from this patch.
Thanks for reporting this bug, and thanks for making it a high quality
bug report.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2013-09-01 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 8:50 bug#15207: 24.2; C Highlight colors around CV-modifiers Gauthier Östervall
2013-09-01 9:10 ` Alan Mackenzie [this message]
2013-09-18 20:59 ` Alan Mackenzie
[not found] <20130901091027.GA2959@acm.acm>
2013-09-25 15:42 ` Gauthier Östervall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130901091027.GA2959__4999.61520913548$1378026751$gmane$org@acm.acm' \
--to=acm@muc.de \
--cc=15207@debbugs.gnu.org \
--cc=gauthier@ostervall.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.