From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladimir Lomov <lomov.vl@gmail.com>
Subject: [BUG][PATCH] Commit '3142297d69f6063221215757a3ba9c74adcf3e43'
 breaks some my files
Date: Mon, 29 Jul 2013 13:17:26 +0900
Message-ID: <20130729041726.GA697@smoon>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lomov.vl@gmail.com>) id 1V3etu-0003XA-KG
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 00:17:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lomov.vl@gmail.com>) id 1V3etp-0003KC-5Y
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 00:17:38 -0400
Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:56037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lomov.vl@gmail.com>) id 1V3eto-0003K5-Tw
	for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 00:17:33 -0400
Received: by mail-la0-f47.google.com with SMTP id eo20so2026551lab.6
	for <emacs-orgmode@gnu.org>; Sun, 28 Jul 2013 21:17:31 -0700 (PDT)
Received: from smoon ([141.105.33.55])
	by mx.google.com with ESMTPSA id k10sm5320073lbl.10.2013.07.28.21.17.29
	for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Sun, 28 Jul 2013 21:17:30 -0700 (PDT)
Content-Disposition: inline
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: General discussions about Org-mode <emacs-orgmode@gnu.org>

Hello,
as title states, commit '3142297d69f6063221215757a3ba9c74adcf3e43'
breaks one of my Org document (I have many but faced with a bug only
with particular one). In that file tables contain data (three columns,
one header) which are transformed and tangle to files (xml, txt). Before
the commit '3142297d69f6063221215757a3ba9c74adcf3e43' all works fine,
begining with it I can't tangle files with error message
BEGIN_EXAMPLE
  mapc: Wrong type argument: consp, nil
END_EXAMPLE

By means of trial-and-error I made small patch which fixes the problem
for me. As I'm know very few in Emacs Lisp I'm not sure if my fix is
correct, so I just added two lines without "proper" reindenting of whole
block.

BEGIN_EXAMPLE
diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index c2722db..013646b 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2353,6 +2353,7 @@ parameters when merging lists."
     (setq vars (reverse vars))
     (while vars (setq params (cons (cons :var (cddr (pop vars))) params)))
     ;; clear out col-names and row-names for replaced variables
+    (when (and (consp :colname-names) (consp :rowname-names))
     (mapc
      (lambda (name)
        (mapc
@@ -2365,6 +2366,7 @@ parameters when merging lists."
 				  params)))
 	(list :colname-names :rowname-names)))
      clearnames)
+    )
     (mapc
      (lambda (hd)
        (let ((key (intern (concat ":" (symbol-name hd))))
END_EXAMPLE


P.S. I was lazy to prepare MWE. The mentioned document is available at
https://github.com/vp1981/scripts/blob/master/docs/openbox/rc.org

---
WBR, Vladimir Lomov


-- 
pessimist:
	A man who spends all his time worrying about how he can keep the
	wolf from the door.

optimist:
	A man who refuses to see the wolf until he seizes the seat of
	his pants.

opportunist:
	A man who invites the wolf in and appears the next day in a fur coat.