From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Gregor Zattler Newsgroups: gmane.emacs.help,gmane.emacs.devel Subject: bisected to commit since when this error occours (was: Re: isearch+ provoces error when starting eshell) Date: Sun, 2 Jun 2013 15:46:50 +0200 Message-ID: <20130602134650.GA27694@boo.workgroup> References: <20130531222203.GA2380@boo.workgroup> <54634406-dce7-432b-a456-32749e186f01@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1370180892 25069 80.91.229.3 (2 Jun 2013 13:48:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Jun 2013 13:48:12 +0000 (UTC) To: help-gnu-emacs , emacs-devel Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Jun 02 15:48:13 2013 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uj8dl-0000nj-TU for geh-help-gnu-emacs@m.gmane.org; Sun, 02 Jun 2013 15:48:10 +0200 Original-Received: from localhost ([::1]:38077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uj8dl-0007ie-Eo for geh-help-gnu-emacs@m.gmane.org; Sun, 02 Jun 2013 09:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uj8dW-0007iN-8W for help-gnu-emacs@gnu.org; Sun, 02 Jun 2013 09:47:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uj8dR-0004MG-NQ for help-gnu-emacs@gnu.org; Sun, 02 Jun 2013 09:47:54 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uj8dR-0004Lz-En for help-gnu-emacs@gnu.org; Sun, 02 Jun 2013 09:47:49 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.17]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MW5It-1UtpuM2T0L-00XOS3 for ; Sun, 02 Jun 2013 15:47:47 +0200 Original-Received: (qmail invoked by alias); 02 Jun 2013 13:47:47 -0000 Original-Received: from p57BB9D56.dip0.t-ipconnect.de (EHLO boo.workgroup) [87.187.157.86] by mail.gmx.net (mp017) with SMTP; 02 Jun 2013 15:47:47 +0200 X-Authenticated: #19296480 X-Provags-ID: V01U2FsdGVkX18mYIUr/s4mTAmv1sZxug7gKUUpSJ2DzDGzp1OicN oMsndOxmbYhKX7 Original-Received: from grfz by boo.workgroup with local (Exim 4.80) (envelope-from ) id 1Uj8dI-0007vq-8K; Sun, 02 Jun 2013 15:47:40 +0200 Mail-Followup-To: help-gnu-emacs , emacs-devel Content-Disposition: inline In-Reply-To: <54634406-dce7-432b-a456-32749e186f01@default> User-Agent: Mutt/1.5.21 (2010-09-15) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:91223 gmane.emacs.devel:159981 Archived-At: [also to emacs-devel since it is perhaps a bug in gnu emacs] Hi Drew, Emacs developers, * Drew Adams [31. May. 2013]: >> in emacs24 when isearch+ is loaded, starting eshell gives: >> byte-code: Key sequence C-c C-c starts with non-prefix key C-c >> and somehow freezes. It's possible to give a `ls' command but >> not twice. >> >> Minimal example: >> emacs-snapshot -Q -nw -l ~/.emacs.d/elpa/isearch+-20130513.1521/isearch+.el -f eshell >> >> Is this something I should file a bug report for? Where? > You can report Isearch+ problems to me directly. > > I cannot reproduce the problem you see. I tried the following with > Emacs 24.3 (on MS Windows), which should be equivalent to what you are > doing. I built Emacs 24.3 from source and I confirm that this issue is not present in Emacs 23 and Emacs 24.3. I did a git bisect then (see below). > I don't know anything about `emacs-snapshot', it's a weekly release of Emacs trunk for debian and ubuntu. > or what that > Isearch version is in your elpa directory. But I assume it is more or > less the same as what I have. > > emacs -Q -nw -l "C:\mydir\isearch+.el" -f eshell > > Likewise, if I use `emacs -Q -nw' and then load isearch+.el (or > isearch+.elc), and then do `M-x eshell'. > > I can do C-c C-c and ls, any number of times each. > > The only key bindings involving C-c in Isearch+ are these in > `isearch-mode-map' (which means they are in effect while searching, > i.e., after C-s). They are each bound to `isearchp-yank-char': > > C-c > C-y C-c > > But your error message seems to come from the byte-compiler. > When I byte-compile isearch+.el in Emacs 24 I get no such error. > And if I then load isearch+.elc instead of .el, I see no difference. > > I can think of two possibilities, neither of which seems like it > should really explain the problem you're seeing: > > 1. I neglected to include (eval-when-compile (require 'cl)) in the file. > I've just added it now and uploaded isearch+.el to Emacs Wiki, here: > http://www.emacswiki.org/emacs-en/download/isearch%2b.el > You might try that to see if it makes a difference (I doubt it). I deleted isearch.elc and downloaded your newest version: same problem with newest Emacs and not with emacs23 and 24.3. > 2. I believe there have been some byte-compiler problems in some recent > Emacs development builds. Perhaps that is the problem. I'm by no means > sure there are any such problems, but I think I saw some messages about > it. No idea whether, if there are some byte-compiler problems, they are > relevant to what you're seeing here. > > Anyway, try loading the source file (not .elc) directly. Try this, to > see if it makes any difference: > > Delete isearch+.elc, so you use the source file. > > emacs -Q -nw > > Then `M-x load-file isearch+.el' in its directory (or ensure it is in > your `load-path' and use `load-library'). > > Then `M-x eshell' and the rest of your recipe (C-c C-c ls C-c C-c etc.). I tried this and I even deleted eshell.elc but with the same result (fail with newest emacs). > Let me know if you make any progress. Perhaps there is a bug in Emacs > or in isearch+.el, but so far I cannot repro what you see. Sorry. I bisected the Emacs version history. Result is: ffc1d3e25cdae710e0f6057620af05c023a6e710 is the first bad commit commit ffc1d3e25cdae710e0f6057620af05c023a6e710 Author: Glenn Morris Date: Tue May 7 00:57:02 2013 -0700 * lisp/eshell/em-hist.el (eshell-isearch-map): Initialize in the defvar. Remove explicit eshell-isearch-cancel-map. This commit changes the keymap for eshell. But I have no clue of elisp and therefore am not in the position to judge if the commit is wrong or if it exposes some bug in isearch+ or eshell. Thanks for your attention, Gregor