Re: Is this a bug of cc-mode?

Re: Is this a bug of cc-mode?

[Alan Mackenzie]

Hello, Jun.

On Fri, May 24, 2013 at 06:14:23PM +0000, Jun wrote:
> emacs -Q
> C-x C-f /tmp/tmp.c  (should be in c-mode)
> Copy the following c code and paste it to the new buffer, then emacs 
> freezes.

> -------------xxxx-----------------
> LONG Rounding(
>      IN PRTMP_ADAPTER pAd,
>      IN LONG Integer,
>      IN LONG Fraction,
>      IN LONG DenominatorOfTssiRatio)
> -------------xxxx---------------

Yes, this is a bug.  There is a failure setting case-folding somewhere,
with the result that "LONG" is almost, but not quite, interpreted as the
keyword "long".

Thanks for taking the trouble to report it.  I'll get a fix out soon.

-- 
Alan Mackenzie (Nuremberg, Germany).

Is this a bug of cc-mode?

[Jun]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

emacs -Q
C-x C-f /tmp/tmp.c  (should be in c-mode)
Copy the following c code and paste it to the new buffer, then emacs 
freezes.

-------------xxxx-----------------
LONG Rounding(
     IN PRTMP_ADAPTER pAd,
     IN LONG Integer,
     IN LONG Fraction,
     IN LONG DenominatorOfTssiRatio)
-------------xxxx---------------

[-- Attachment #2: Type: text/html, Size: 692 bytes --]

Re: Is this a bug of cc-mode?

[Alan Mackenzie]

Hi, Jun.

On Fri, May 24, 2013 at 06:14:23PM +0000, Jun wrote:
> emacs -Q
> C-x C-f /tmp/tmp.c  (should be in c-mode)
> Copy the following c code and paste it to the new buffer, then emacs 
> freezes.

> -------------xxxx-----------------
> LONG Rounding(
>      IN PRTMP_ADAPTER pAd,
>      IN LONG Integer,
>      IN LONG Fraction,
>      IN LONG DenominatorOfTssiRatio)
> -------------xxxx---------------

I think the following patch fixes things.  Could you try it out, please,
and let me know whether it works properly.  Thanks!


diff -r 5913f459a611 cc-mode.el
--- a/cc-mode.el	Sat May 25 10:56:44 2013 +0000
+++ b/cc-mode.el	Sat May 25 11:15:35 2013 +0000
@@ -1082,7 +1082,7 @@
   ;; This typically sets `syntax-table' properties.
 
   (setq c-just-done-before-change nil)
-  (c-save-buffer-state ()
+  (c-save-buffer-state (case-fold-search)
     ;; When `combine-after-change-calls' is used we might get calls
     ;; with regions outside the current narrowing.  This has been
     ;; observed in Emacs 20.7.



-- 
Alan Mackenzie (Nuremberg, Germany).

Re: Is this a bug of cc-mode?

[Jun]

On 05/25/2013 11:19 AM, Alan Mackenzie wrote:
> Hi, Jun.
>
> On Fri, May 24, 2013 at 06:14:23PM +0000, Jun wrote:
>> emacs -Q
>> C-x C-f /tmp/tmp.c  (should be in c-mode)
>> Copy the following c code and paste it to the new buffer, then emacs
>> freezes.
>> -------------xxxx-----------------
>> LONG Rounding(
>>       IN PRTMP_ADAPTER pAd,
>>       IN LONG Integer,
>>       IN LONG Fraction,
>>       IN LONG DenominatorOfTssiRatio)
>> -------------xxxx---------------
> I think the following patch fixes things.  Could you try it out, please,
> and let me know whether it works properly.  Thanks!
>
>
> diff -r 5913f459a611 cc-mode.el
> --- a/cc-mode.el	Sat May 25 10:56:44 2013 +0000
> +++ b/cc-mode.el	Sat May 25 11:15:35 2013 +0000
> @@ -1082,7 +1082,7 @@
>     ;; This typically sets `syntax-table' properties.
>   
>     (setq c-just-done-before-change nil)
> -  (c-save-buffer-state ()
> +  (c-save-buffer-state (case-fold-search)
>       ;; When `combine-after-change-calls' is used we might get calls
>       ;; with regions outside the current narrowing.  This has been
>       ;; observed in Emacs 20.7.
>
>
>
It works well now with your patch. Thank you.