From: Xue Fuqiao <xfq.free@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: About commit style
Date: Mon, 8 Apr 2013 06:22:12 +0800 [thread overview]
Message-ID: <20130408062212.a69bafe954880d8b5b7b01b0@gmail.com> (raw)
In-Reply-To: <jwvli8u1maw.fsf-monnier+emacs@gnu.org>
On Sun, 07 Apr 2013 11:48:47 -0400
Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > * Reindent the file using the default indentation parameters.
>
> No. You can only fix local misindentation.
>
> Any "bulk" cosmetic changes are annoying because they are sure to bump into
> someone's local changes, creating spurious conflicts.
>
> > * Change some code from putting close-parentheses on lines by themselves
> > to Lisp style. (Although this almost never happened.)
>
> Same here: doing it somewhere where you're already making other changes
> is fine, but doing it systematically is not.
>
> > * Change the comments to satisfy (info "(elisp) Comment Tips").
>
> Idem.
I see, thanks.
--
Xue Fuqiao
http://www.gnu.org/software/emacs/
prev parent reply other threads:[~2013-04-07 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 8:13 About commit style Xue Fuqiao
2013-04-06 8:52 ` Eli Zaretskii
2013-04-06 9:08 ` Eli Zaretskii
2013-04-06 11:03 ` Xue Fuqiao
2013-04-06 13:10 ` Stefan Monnier
2013-04-06 15:02 ` Eli Zaretskii
2013-04-06 15:32 ` Stefan Monnier
2013-04-06 15:46 ` Andreas Röhler
2013-04-07 6:17 ` Xue Fuqiao
2013-04-07 15:41 ` Eli Zaretskii
2013-04-07 15:48 ` Stefan Monnier
2013-04-07 22:22 ` Xue Fuqiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408062212.a69bafe954880d8b5b7b01b0@gmail.com \
--to=xfq.free@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.