From: Giorgos Keramidas <gkeramidas@gmail.com>
To: emacs-devel@gnu.org
Cc: Roland Winkler <winkler@gnu.org>
Subject: Recent read-face patch breaks `M-x customize-face'
Date: Fri, 5 Apr 2013 19:50:34 +0200 [thread overview]
Message-ID: <20130405175032.GA29138@saturn> (raw)
Hi all,
I noticed that `M-x customize-face' triggers an error in a recent build
of Emacs trunk, and managed to track this backtrace:
Debugger entered--Lisp error: (wrong-type-argument sequencep 97)
mapconcat((lambda (f) (if (symbolp f) (symbol-name f) f)) "all faces" ", ")
(setq default (mapconcat (function (lambda (f) (if (symbolp f) (symbol-name f) f))) default ", "))
(if default (setq default (mapconcat (function (lambda (f) (if (symbolp f) (symbol-name f) f))) defau$
read-face-name("Customize face" "all faces" t)
(list (read-face-name "Customize face" "all faces" t))
call-interactively(customize-face record nil)
command-execute(customize-face record)
execute-extended-command(nil "customize-face")
call-interactively(execute-extended-command nil nil)
command-execute(execute-extended-command)
To the changes of this commit:
commit 605625d262e5e4bf996691027c755c65061492b1
Author: Roland Winkler <winkler@gnu.org>
Date: Wed Apr 3 21:12:25 2013 -0500
lisp/faces.el (read-face-name): Behave as promised by the docstring.
| diff --git a/lisp/ChangeLog b/lisp/ChangeLog
| index 2b86faf..7ee201a 100644
| --- a/lisp/ChangeLog
| +++ b/lisp/ChangeLog
| @@ -1,3 +1,9 @@
| +2013-04-04 Roland Winkler <winkler@gnu.org>
| +
| + * faces.el (read-face-name): Behave as promised by the docstring.
| + Assume that arg default is a list of faces.
| + (describe-face): Call read-face-name with list of default faces.
| +
| 2013-04-04 Thierry Volpiatto <thierry.volpiatto@gmail.com>
|
| * bookmark.el: Fix deletion of bookmarks (bug#13972).
Does customize-face depend on some bogus assumption that this commit
has now rendered broken??
next reply other threads:[~2013-04-05 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 17:50 Giorgos Keramidas [this message]
2013-04-05 17:52 ` Recent read-face patch breaks `M-x customize-face' Giorgos Keramidas
2013-04-05 18:56 ` Roland Winkler
2013-04-05 19:00 ` Roland Winkler
2013-04-05 19:04 ` Giorgos Keramidas
2013-04-05 21:40 ` Stefan Monnier
2013-04-06 11:55 ` Roland Winkler
2013-04-06 14:02 ` Stefan Monnier
2013-04-06 15:50 ` Γιώργος Κεραμίδας
2013-04-06 21:22 ` Roland Winkler
2013-04-07 0:29 ` Stefan Monnier
2013-04-07 21:15 ` Roland Winkler
2013-04-13 1:15 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405175032.GA29138@saturn \
--to=gkeramidas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.