From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Xue Fuqiao Newsgroups: gmane.emacs.devel Subject: Re: Edebug-x visual extensions to Edebug Date: Tue, 12 Mar 2013 21:53:23 +0800 Organization: The Church of Emacs Message-ID: <20130312215323.4b71376ef6ee2ad6d6027d1e@gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1363096431 31463 80.91.229.3 (12 Mar 2013 13:53:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 13:53:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Scott Barnett Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 14:54:16 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFPee-0005Ls-Uf for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 14:54:13 +0100 Original-Received: from localhost ([::1]:39863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPeI-0005YF-NY for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 09:53:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPe7-0005RW-5J for emacs-devel@gnu.org; Tue, 12 Mar 2013 09:53:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFPe3-0002Eg-Gu for emacs-devel@gnu.org; Tue, 12 Mar 2013 09:53:39 -0400 Original-Received: from mail-pb0-f50.google.com ([209.85.160.50]:52176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFPe3-0002ES-B3 for emacs-devel@gnu.org; Tue, 12 Mar 2013 09:53:35 -0400 Original-Received: by mail-pb0-f50.google.com with SMTP id up1so4955568pbc.23 for ; Tue, 12 Mar 2013 06:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:in-reply-to :references:organization:x-mailer:mime-version:content-type :content-transfer-encoding; bh=KKW8lwvxC1tHTsBdShInFAr7Cr9UP+OPXYLF+UAqCJA=; b=Wv2Q1DZhFrUT24WVi2Xp+aMhagrPPrlu4N2Xeh88hQFG5KuyB9DOsGci4AT5rLIn8V 1tMckMbH+LvKAk/lLGUHV7AVRX5+bbl37v0zyjdl/WXgVYmjENa8BFvRMBEGup3mlEVV Q0w7R3siyLsajA8ZgfKdWFMtILDN0gf+udZYFtTUB7IztYWtXHpycy/Y0vNq5+pzpKmi RTnnPWzevTou0mQ7/KlLcooXB0e/hIqiRuhLOY5aIwYzllQ1WzW/QXB59M6UX1dZ9KC0 KdWcr5kj2dr2rIpx7fBygUHUbwrP+dazZAD2WmgObzpsnfBhOHxLuWlULdazJW/5GgHy fbcw== X-Received: by 10.68.234.100 with SMTP id ud4mr37092645pbc.8.1363096414276; Tue, 12 Mar 2013 06:53:34 -0700 (PDT) Original-Received: from Emacs ([123.114.126.128]) by mx.google.com with ESMTPS id gf6sm25152589pbc.24.2013.03.12.06.53.29 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Mar 2013 06:53:33 -0700 (PDT) In-Reply-To: X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157773 Archived-At: On Tue, 12 Mar 2013 22:56:13 +1100 Scott Barnett wrote: > I made a small extension to Edebug that highlights breakpoints, shows a > list of currently instrumented functions and provides a couple of other > extras to make Edebug easier for me to use. A couple of people on #emacs > suggested I tried to get it into Emacs so I am wondering if it is something > that you would be interested in including. The project can be found here: > https://github.com/ScottyB/edebug-x. From what I understand I have to > sign some forms to say you can keep it which I am fine with. Thanks for your contribution. I have read the code roughly. I have 3 suggestions first: 1. Since its not large (now), it is better to integrate it into edebug.el. If it is as large as Dired Extra, it can be separated. 2. There should be two spaces after a sentence in doc string. 3. Please add some comments. > If this is something that should be included please let me know of the next > steps. To include this library, I suggest you: 1. Do copyright assignment if you haven't done it before. 2. Change the use of `cl' to `cl-lib'. 3. Avoid using `defadvice'. 4. Document your changes, then add an item to the NEWS file. 5. Write a ChangeLog entry. See "Change Log Concepts" node of the GNU Coding Standards. 6. Write a diff to this list or bug-gnu-emacs@gnu.org. 7. IIRC the library `dash' is not distributed with either GNU Emacs or GNU ELPA, you'd better not use it. 8. Please indent this file using the default indentation parameters. BTW I have also wrote a minor patch for edebug (and debugger-mode): http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13777 -- Best regards, Xue Fuqiao. http://www.emacswiki.org/emacs/XueFuqiao