Re: Edebug-x visual extensions to Edebug

[Xue Fuqiao <xfq.free@gmail.com>]

On Tue, 12 Mar 2013 22:56:13 +1100
Scott Barnett <scott.n.barnett@gmail.com> wrote:

> I made a small extension to Edebug that highlights breakpoints, shows a
> list of currently instrumented functions and provides a couple of other
> extras to make Edebug easier for me to use. A couple of people on #emacs
> suggested I tried to get it into Emacs so I am wondering if it is something
> that you would be interested in including. The project can be found here:
> https://github.com/ScottyB/edebug-x.   From what I understand I have to
> sign some forms to say you can keep it which I am fine with.

Thanks for your contribution.  I have read the code roughly.  I have 3
suggestions first:

1. Since its not large (now), it is better to integrate it into
edebug.el.  If it is as large as Dired Extra, it can be separated.

2. There should be two spaces after a sentence in doc string.

3. Please add some comments.

> If this is something that should be included please let me know of the next
> steps.

To include this library, I suggest you:

1. Do copyright assignment if you haven't done it before.

2. Change the use of `cl' to `cl-lib'.

3. Avoid using `defadvice'.

4. Document your changes, then add an item to the NEWS file.

5. Write a ChangeLog entry.  See "Change Log Concepts" node of the GNU Coding Standards.

6. Write a diff to this list or bug-gnu-emacs@gnu.org.

7. IIRC the library `dash' is not distributed with either GNU Emacs or
GNU ELPA, you'd better not use it.

8. Please indent this file using the default indentation parameters.

BTW I have also wrote a minor patch for edebug (and debugger-mode):

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13777

-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao