all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#13858: [PATCH] Comment fix for loadup.el
@ 2013-03-02  8:51 Xue Fuqiao
  2013-03-03  2:11 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: Xue Fuqiao @ 2013-03-02  8:51 UTC (permalink / raw
  To: 13858

In (info "(elisp) Comment Tips"):

  `;'
     Comments that start with a single semicolon, `;', should all be
     aligned to the same column on the right of the source code.  Such
     comments usually explain how the code on that line does its job.

But in loadup.el, some comments do not follow this convention.  The following
patch fixes this problem:

*** loadup.el	2013-02-03 09:46:50.383143000 +0800
--- loadup.el.new	2013-03-02 16:45:27.079265181 +0800
***************
*** 276,287 ****
  (load "vc/ediff-hook")
  (if (fboundp 'x-show-tip) (load "tooltip"))
  
! ;If you want additional libraries to be preloaded and their
! ;doc strings kept in the DOC file rather than in core,
! ;you may load them with a "site-load.el" file.
! ;But you must also cause them to be scanned when the DOC file
! ;is generated.
! ;For other systems, you must edit ../src/Makefile.in.
  (load "site-load" t)
  
  ;; Determine which last version number to use
--- 276,287 ----
  (load "vc/ediff-hook")
  (if (fboundp 'x-show-tip) (load "tooltip"))
  
! ;; If you want additional libraries to be preloaded and their
! ;; doc strings kept in the DOC file rather than in core,
! ;; you may load them with a "site-load.el" file.
! ;; But you must also cause them to be scanned when the DOC file
! ;; is generated.
! ;; For systems other than GNU, you must edit ../src/Makefile.in.
  (load "site-load" t)
  
  ;; Determine which last version number to use


*** ChangeLog	2013-02-24 06:49:38.358835000 +0800
--- ChangeLog.new	2013-03-02 16:45:16.375212099 +0800
***************
*** 1,3 ****
--- 1,7 ----
+ 2013-03-02  Xue Fuqiao  <xfq.free@gmail.com>
+ 
+ 	* loadup.el: Change the comment to fit in the comment conventions.
+ 
  2013-02-23  Peter Kleiweg  <p.c.j.kleiweg@rug.nl>
  
  	* progmodes/ps-mode.el (ps-mode-version): Bump to 1.1i.

-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#13858: [PATCH] Comment fix for loadup.el
  2013-03-02  8:51 bug#13858: [PATCH] Comment fix for loadup.el Xue Fuqiao
@ 2013-03-03  2:11 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2013-03-03  2:11 UTC (permalink / raw
  To: 13858-done


Thanks, but please don't report cosmetic trivia like this as bugs.
If we start down this road it will never end.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-03  2:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-02  8:51 bug#13858: [PATCH] Comment fix for loadup.el Xue Fuqiao
2013-03-03  2:11 ` Glenn Morris

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.