From: Xue Fuqiao <xfq.free@gmail.com>
To: 13858@debbugs.gnu.org
Subject: bug#13858: [PATCH] Comment fix for loadup.el
Date: Sat, 2 Mar 2013 16:51:02 +0800 [thread overview]
Message-ID: <20130302165102.6947da9eea9c8ce470c517d4@gmail.com> (raw)
In (info "(elisp) Comment Tips"):
`;'
Comments that start with a single semicolon, `;', should all be
aligned to the same column on the right of the source code. Such
comments usually explain how the code on that line does its job.
But in loadup.el, some comments do not follow this convention. The following
patch fixes this problem:
*** loadup.el 2013-02-03 09:46:50.383143000 +0800
--- loadup.el.new 2013-03-02 16:45:27.079265181 +0800
***************
*** 276,287 ****
(load "vc/ediff-hook")
(if (fboundp 'x-show-tip) (load "tooltip"))
! ;If you want additional libraries to be preloaded and their
! ;doc strings kept in the DOC file rather than in core,
! ;you may load them with a "site-load.el" file.
! ;But you must also cause them to be scanned when the DOC file
! ;is generated.
! ;For other systems, you must edit ../src/Makefile.in.
(load "site-load" t)
;; Determine which last version number to use
--- 276,287 ----
(load "vc/ediff-hook")
(if (fboundp 'x-show-tip) (load "tooltip"))
! ;; If you want additional libraries to be preloaded and their
! ;; doc strings kept in the DOC file rather than in core,
! ;; you may load them with a "site-load.el" file.
! ;; But you must also cause them to be scanned when the DOC file
! ;; is generated.
! ;; For systems other than GNU, you must edit ../src/Makefile.in.
(load "site-load" t)
;; Determine which last version number to use
*** ChangeLog 2013-02-24 06:49:38.358835000 +0800
--- ChangeLog.new 2013-03-02 16:45:16.375212099 +0800
***************
*** 1,3 ****
--- 1,7 ----
+ 2013-03-02 Xue Fuqiao <xfq.free@gmail.com>
+
+ * loadup.el: Change the comment to fit in the comment conventions.
+
2013-02-23 Peter Kleiweg <p.c.j.kleiweg@rug.nl>
* progmodes/ps-mode.el (ps-mode-version): Bump to 1.1i.
--
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao
next reply other threads:[~2013-03-02 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 8:51 Xue Fuqiao [this message]
2013-03-03 2:11 ` bug#13858: [PATCH] Comment fix for loadup.el Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130302165102.6947da9eea9c8ce470c517d4@gmail.com \
--to=xfq.free@gmail.com \
--cc=13858@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.