all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Xue Fuqiao <xfq.free@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 13740@debbugs.gnu.org
Subject: bug#13740: About a coding convention
Date: Thu, 21 Feb 2013 08:28:57 +0800	[thread overview]
Message-ID: <20130221082857.3ad60989ae6f64d91b90bd42@gmail.com> (raw)
In-Reply-To: <ywa9r0f58o.fsf@fencepost.gnu.org>

On Tue, 19 Feb 2013 14:55:35 -0500
Glenn Morris <rgm@gnu.org> wrote:

> Xue Fuqiao wrote:
> > In (info "(elisp) Coding Conventions"):
> >
> >    * Constructs that define a function or variable should be macros,
> >      not functions, and their names should start with `define-'.  The
> >      macro should receive the name to be defined as the first argument.
> >      That will help various tools find the definition automatically.
> >      Avoid constructing the names in the macro itself, since that would
> >      confuse these tools.
> >
> > I think macros like `cl-defsubst', `cl-defun' should be mentioned here.

> Why?

They are macros that define functions, but they don't start with `define-'.

>  What would you say about them?

Maybe something like this:

Constructs that define a function or variable should be macros, not functions, and their names should start with `define-', except for some macros in `cl-lib', like `cl-defsubst' and `cl-defun'.

-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao





  reply	other threads:[~2013-02-21  0:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  0:25 bug#13740: About a coding convention Xue Fuqiao
2013-02-19 19:55 ` Glenn Morris
2013-02-21  0:28   ` Xue Fuqiao [this message]
     [not found]     ` <8738wqa0sp@ch.ristopher.com>
2013-02-21  2:10       ` Xue Fuqiao
2013-02-21 15:21     ` Stefan Monnier
2013-02-21 17:01     ` Glenn Morris
2020-08-07 11:23       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130221082857.3ad60989ae6f64d91b90bd42@gmail.com \
    --to=xfq.free@gmail.com \
    --cc=13740@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.