From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.bugs Subject: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Date: Thu, 14 Jun 2012 12:01:21 +0900 (JST) Organization: Red Hat Japan, Inc. Message-ID: <20120614.120121.1235549761581179800.yamato@redhat.com> References: <20120614.023511.637296055128807025.yamato@redhat.com> <2ny5nrc6l4.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1339642941 2287 80.91.229.3 (14 Jun 2012 03:02:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2012 03:02:21 +0000 (UTC) Cc: 11698@debbugs.gnu.org To: rgm@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 05:02:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sf0K8-0002Gz-RY for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2012 05:02:16 +0200 Original-Received: from localhost ([::1]:49658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf0K8-0006kA-M3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jun 2012 23:02:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf0K5-0006jq-NM for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 23:02:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf0K3-0002QX-Vj for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 23:02:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf0K3-0002PJ-S3 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 23:02:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sf0Mn-0004Dh-Vw for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 23:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Masatake YAMATO Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2012 03:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11698-submit@debbugs.gnu.org id=B11698.133964306016171 (code B ref 11698); Thu, 14 Jun 2012 03:05:01 +0000 Original-Received: (at 11698) by debbugs.gnu.org; 14 Jun 2012 03:04:20 +0000 Original-Received: from localhost ([127.0.0.1]:41550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf0M7-0004Ck-0T for submit@debbugs.gnu.org; Wed, 13 Jun 2012 23:04:20 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:49280) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf0M4-0004Cc-7Y for 11698@debbugs.gnu.org; Wed, 13 Jun 2012 23:04:18 -0400 Original-Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5E31Nh3025992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 23:01:23 -0400 Original-Received: from localhost (vpn-232-169.phx2.redhat.com [10.3.232.169]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5E31MDF005049; Wed, 13 Jun 2012 23:01:22 -0400 In-Reply-To: <2ny5nrc6l4.fsf@fencepost.gnu.org> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60961 Archived-At: Glenn Morris wrote: > Masatake YAMATO wrote: > >> ! mouse-face highlight > > Is this really desirable? Many other parts of the mode line can be > clicked on, but do not have a mouse-face. Isn't the change in cursor > sufficient? It seems that mode-line-highlight is used for mouse-face. How do you think to use it in which-func for keeping consistency between other area on the mode line? I think sometimes cursor is not sufficient. It doesn't tells just the pixel under the cursor is something clickable. The feed-back with mouse-face can tell the area under the cursor is something clickable. Sometimes it is obvious that the area even without mouse face. However, it may be a bit difficult to recognize one-character area like area for buffer-coding system. === modified file 'lisp/progmodes/which-func.el' *** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000 --- lisp/progmodes/which-func.el 2012-06-14 02:55:51 +0000 *************** *** 144,150 **** (:propertize which-func-current local-map ,which-func-keymap face which-func ! ;;mouse-face highlight ; currently not evaluated :-( help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") --- 144,150 ---- (:propertize which-func-current local-map ,which-func-keymap face which-func ! mouse-face mode-line-highlight help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end")