all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Masatake YAMATO <yamato@redhat.com>
To: rgm@gnu.org
Cc: 11698@debbugs.gnu.org
Subject: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func
Date: Thu, 14 Jun 2012 12:01:21 +0900 (JST)	[thread overview]
Message-ID: <20120614.120121.1235549761581179800.yamato@redhat.com> (raw)
In-Reply-To: <2ny5nrc6l4.fsf@fencepost.gnu.org>

Glenn Morris wrote:
> Masatake YAMATO wrote:
> 
>> ! 		 mouse-face highlight
> 
> Is this really desirable? Many other parts of the mode line can be
> clicked on, but do not have a mouse-face. Isn't the change in cursor
> sufficient?


It seems that mode-line-highlight is used for mouse-face.

How do you think to use it in which-func for keeping consistency
between other area on the mode line?

I think sometimes cursor is not sufficient. It doesn't tells just the
pixel under the cursor is something clickable. The feed-back with
mouse-face can tell the area under the cursor is something
clickable. Sometimes it is obvious that the area even without mouse
face. However, it may be a bit difficult to recognize one-character
area like area for buffer-coding system. 


=== modified file 'lisp/progmodes/which-func.el'
*** lisp/progmodes/which-func.el	2012-06-03 11:10:44 +0000
--- lisp/progmodes/which-func.el	2012-06-14 02:55:51 +0000
***************
*** 144,150 ****
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 ;;mouse-face highlight	; currently not evaluated :-(
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")
--- 144,150 ----
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 mouse-face mode-line-highlight
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")








  reply	other threads:[~2012-06-14  3:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 17:35 bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Masatake YAMATO
2012-06-13 20:14 ` Glenn Morris
2012-06-14  3:01   ` Masatake YAMATO [this message]
2012-06-25  7:13     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120614.120121.1235549761581179800.yamato@redhat.com \
    --to=yamato@redhat.com \
    --cc=11698@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.