Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108407: textmodex/{ispell, flyspell}.el: Decrease XEmacs incompatibilities.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108407: textmodex/{ispell, flyspell}.el: Decrease XEmacs incompatibilities.

[Juanma Barranquero]

On Mon, May 28, 2012 at 6:11 PM, Agustin Martin
<agustin.martin@hispalinux.es> wrote:
> ------------------------------------------------------------
> revno: 108407
> committer: Agustin Martin <agustin.martin@hispalinux.es>
> branch nick: trunk
> timestamp: Mon 2012-05-28 18:11:15 +0200
> message:
>  textmodex/{ispell,flyspell}.el: Decrease XEmacs incompatibilities.

>  * ispell.el:
>    (ispell-with-no-warnings): XEmacs alternative `with-no-warnings'
>    definition or Emacs alias.

That does not avoid warnings on Emacs, likely because with-no-warnings
is dealt specially by the bytecompiler.

  In ispell-message:
  ispell.el:3733:49:Warning: reference to free variable
      `sc-reference-tag-string'
  ispell.el:3738:48:Warning: reference to free variable
      `message-cite-prefix-regexp'
  ispell.el:3744:49:Warning: reference to free variable `mh-ins-buf-prefix'

  In end of data:
  ispell.el:4048:1:Warning: the function `sc-cite-regexp' is not known to be
      defined.


    Juanma

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108407: textmodex/{ispell, flyspell}.el: Decrease XEmacs incompatibilities.

[Agustin Martin]

On Wed, May 30, 2012 at 04:33:07PM +0200, Juanma Barranquero wrote:
> On Mon, May 28, 2012 at 6:11 PM, Agustin Martin
> <agustin.martin@hispalinux.es> wrote:
> > ------------------------------------------------------------
> > revno: 108407
> > committer: Agustin Martin <agustin.martin@hispalinux.es>
> > branch nick: trunk
> > timestamp: Mon 2012-05-28 18:11:15 +0200
> > message:
> >  textmodex/{ispell,flyspell}.el: Decrease XEmacs incompatibilities.
> 
> >  * ispell.el:
> >    (ispell-with-no-warnings): XEmacs alternative `with-no-warnings'
> >    definition or Emacs alias.
> 
> That does not avoid warnings on Emacs, likely because with-no-warnings
> is dealt specially by the bytecompiler.
> 
>   In ispell-message:
>   ispell.el:3733:49:Warning: reference to free variable
>       `sc-reference-tag-string'
>   ispell.el:3738:48:Warning: reference to free variable
>       `message-cite-prefix-regexp'
>   ispell.el:3744:49:Warning: reference to free variable `mh-ins-buf-prefix'
> 
>   In end of data:
>   ispell.el:4048:1:Warning: the function `sc-cite-regexp' is not known to be
>       defined.

Thanks for the info, did not notice that I byte compiled with
byte-compile-warnings nil. Now I see even another couple of obsolete
interactive-p uses. 

Macro definition taken from orgmode seems to do a better job

(defmacro ispell-with-no-warnings (&rest body)
  (cons (if (fboundp 'with-no-warnings) 'with-no-warnings 'progn) body))

-- 
Agustin