Re: bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

[Toby Cubitt <tsc25@cantab.net>]

On Sun, Apr 22, 2012 at 08:46:03AM +0200, Bastien wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
> > Was there some reason to reject Eli's suggested fix of enlarging the
> > calendar window by 1 line? As it stands, if anyone customizes the new
> > org-date-selected face to be bold (the highlighted date *is* a little
> > less visible now), it will cause the same problem as before. And the fact
> > that it's caused by making the font bold is not at all obvious...at
> > least, it wasn't obvious to me! Eli's fix works more generally.
> 
> This general solution comes with a cost -- enlarging the window by
> one-line for everyone just because a few users will use bold fonts and 
> have a problem while displaying... does not feel right to me.

Fair enough.

> > Anyway, since I now know how to patch things if I do decide I want a bold
> > font, it's not a big issue for me.
> >
> > In the patch I posted, I also took the opportunity to set `cursor-type'
> > to nil when opening the calendar in `org-read-date'. The cursor obscures
> > one digit of the selected date, making that bit harder to read (as well
> > as looking ugly). Did you intend to reject this change too?
> 
> I did because I found the not-bold-anymore face wasn't visible enough,
> and the shallow cursor made it visible.
> 
> I use inverse-video now for this face, so cursor-type nil is okay, 
> I applied a patch with this.

Inverse-video is a good solution - thanks!

Toby
-- 
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: tsc25@cantab.net
web:   www.dr-qubit.org