From: jaalto <jari.aalto@cante.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 10956@debbugs.gnu.org
Subject: bug#10956: make-mode.el - improve makefile-warn-suspicious-lines
Date: Wed, 21 Mar 2012 14:52:42 -0400 [thread overview]
Message-ID: <20120321185242.GE28863@taiko.cante.net> (raw)
In-Reply-To: <jwvk42d6dv8.fsf-monnier+emacs@gnu.org>
On 2012-03-21 13:54, Stefan Monnier wrote:
| > Here is a small patch to check any extra whitespace at the beginning of
| > line. The patch is against Emacs Vcs-Git ba7322c dated 2012-02-29.
|
| I must be missing something. All it does is change a "\t+$" to
| "[ \t]+$", so it's not really "at the beginning of line" (tho there's
| also a "^" in the regexp, so it really only applies to whitespace-only
| lines).
| I don't think we want to consider lines made up of spaces as suspicious.
It would be good if any whitespace only line were flagged as suspicious,
not just \t, like in:
[SPACE][TAB][SPACE]
[SPACE][TAB]
[TAB][SPACE]
[TAB]
These extra "whitespace" lines are easily missed unless
whitespace-mode is on.
Jari
next prev parent reply other threads:[~2012-03-21 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:22 bug#10956: make-mode.el - improve makefile-warn-suspicious-lines Jari Aalto
2012-03-21 17:54 ` Stefan Monnier
2012-03-21 18:52 ` jaalto [this message]
2012-03-22 16:36 ` Stefan Monnier
2014-02-06 0:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321185242.GE28863@taiko.cante.net \
--to=jari.aalto@cante.net \
--cc=10956@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.