all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 10987@debbugs.gnu.org
Subject: bug#10987: ibuffer: remove "No Buffers" error
Date: Sun, 11 Mar 2012 19:34:24 +0100	[thread overview]
Message-ID: <20120311183439.779981FDFB@saturn.ch.ristopher.com> (raw)
In-Reply-To: <877gyrt55n.fsf@gnu.org> (Chong Yidong's message of "Mon, 12 Mar 2012 01:32:20 +0800")

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Chong Yidong <cyd@gnu.org> writes:

> Thanks.  I committed your patch to trunk.

Thank you very much.  I just skimmed through ibuffer.el and found the
same error in ibuffer-redisplay.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ibuffer2.diff --]
[-- Type: text/x-diff, Size: 1120 bytes --]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4710434..5b11660 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-11  Christopher Schmidt  <christopher@ch.ristopher.com>
+
+	* ibuffer.el (ibuffer-redisplay): Remove gratuitous error
+	(Bug#10987).
+
 2012-03-11  Michael Albinus  <michael.albinus@gmx.de>
 
 	* autorevert.el (auto-revert-handler): Ensure, that
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 7db4cc4..7e5a4aa 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2173,11 +2173,10 @@ If optional arg SILENT is non-nil, do not display progress messages."
 		   (cadr bufs))
 		 (ibuffer-current-buffers-with-marks bufs)
 		 ibuffer-display-maybe-show-predicates)))
-    (when (null blist)
-      (if (and (featurep 'ibuf-ext)
+    (when (and (null blist)
+	       (featurep 'ibuf-ext)
 	       ibuffer-filtering-qualifiers)
-	  (message "No buffers! (note: filtering in effect)")
-	(error "No buffers!")))
+      (message "No buffers! (note: filtering in effect)"))
     (unless silent
       (message "Updating buffer list..."))
     (ibuffer-redisplay-engine blist arg)

[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


        Christopher

  reply	other threads:[~2012-03-11 18:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10 12:18 bug#10987: ibuffer: remove "No Buffers" error Christopher Schmidt
2012-03-11 17:32 ` Chong Yidong
2012-03-11 18:34   ` Christopher Schmidt [this message]
2012-03-12  2:41     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120311183439.779981FDFB@saturn.ch.ristopher.com \
    --to=christopher@ch.ristopher.com \
    --cc=10987@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.