From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Schmidt Newsgroups: gmane.emacs.bugs Subject: bug#10987: ibuffer: remove "No Buffers" error Date: Sat, 10 Mar 2012 13:18:09 +0100 Message-ID: <20120310121820.042301FDFB@saturn.ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1331381972 21645 80.91.229.3 (10 Mar 2012 12:19:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2012 12:19:32 +0000 (UTC) To: 10987@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 13:19:31 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S6LGk-00089J-8V for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2012 13:19:30 +0100 Original-Received: from localhost ([::1]:54224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LGj-0004bx-EP for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2012 07:19:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LGf-0004bZ-Nf for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:19:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6LGd-0001Hy-Sr for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:19:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LGd-0001Ho-N4 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:19:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S6LjK-0007v2-7L for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2012 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10987 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133138369330372 (code B ref -1); Sat, 10 Mar 2012 12:49:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Mar 2012 12:48:13 +0000 Original-Received: from localhost ([127.0.0.1]:42099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6LiW-0007tp-Vu for submit@debbugs.gnu.org; Sat, 10 Mar 2012 07:48:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43340) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6LiT-0007tg-5L for submit@debbugs.gnu.org; Sat, 10 Mar 2012 07:48:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6LFk-0000vu-FK for submit@debbugs.gnu.org; Sat, 10 Mar 2012 07:18:29 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:49761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LFk-0000vo-9b for submit@debbugs.gnu.org; Sat, 10 Mar 2012 07:18:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LFi-0004aY-JK for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:18:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S6LFg-0000vY-CH for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:18:26 -0500 Original-Received: from ristopher.com ([146.185.21.93]:44965 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S6LFf-0000vN-V0 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2012 07:18:24 -0500 Original-Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 042301FDFB; Sat, 10 Mar 2012 12:18:19 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1331381900; bh=wt4GcoitbYUD3dkaxK52KXHTaGRzvsYm9iYBUJak//Y=; h=From:To:Subject:Date:MIME-Version:Content-Type:Message-Id; b=JfR33qYZeXdOCpqULCDIDck413wYNRXv1c1PHm6OaOQOy5Cg10nkqmNF9mBcaGhJ6 1LxPLTVeyAprc4p5poIgTcuUSK4H0Yp6Xr+Kvam7U45bdWcl9qExTMI6c0V+1/kYyo KzhPu7cimNxs+0nO3wUAHTZA+r1ruR5vNGvKvwZQ= Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57643 Archived-At: --=-=-= Content-Type: text/plain Hi gurus, I noticed a little issue with ibuffer on GNU Emacs 24.0.94.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-03-10. I use ibuffer-never-show-predicates to reduce the list of buffers in ibuffer. This works fine whilst there are buffers for ibuffer to display. If there are no buffers, ibuffer will error (and will leave an unusable ibuffer-buffer behind). What the point behind this error? I think that no buffers is a perfectly legitimate situation. Recipe: emacs -q eval: (require 'ibuf-ext) (push "" ibuffer-never-show-predicates) M-x ibuffer RET I think the whole error should be removed. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ibuffer.diff diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 17be553..7db4cc4 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -2140,11 +2140,10 @@ If optional arg SILENT is non-nil, do not display progress messages." (unless silent (message "Redisplaying current buffer list...")) (let ((blist (ibuffer-current-state-list))) - (when (null blist) - (if (and (featurep 'ibuf-ext) + (when (and (null blist) + (featurep 'ibuf-ext) (or ibuffer-filtering-qualifiers ibuffer-hidden-filter-groups)) - (message "No buffers! (note: filtering in effect)") - (error "No buffers!"))) + (message "No buffers! (note: filtering in effect)")) (ibuffer-redisplay-engine blist t) (unless silent (message "Redisplaying current buffer list...done")) --=-=-= Content-Type: text/plain Christopher --=-=-=--