From: Alan Mackenzie <acm@muc.de>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 10906@debbugs.gnu.org
Subject: bug#10906: 24.0.94; `c-mark-function' does set the mark well
Date: Mon, 5 Mar 2012 18:41:33 +0000 [thread overview]
Message-ID: <20120305184133.GC2824@acm.acm> (raw)
In-Reply-To: <CAH8Pv0g6kcrP_h3656hXXZDPu3o3BQ4Pj_pYqLXN+BbOFYFmnA@mail.gmail.com>
Hello, Dani.
On Fri, Mar 02, 2012 at 12:03:48AM +0100, Dani Moncayo wrote:
> >> > Regarding bug#10906, I think `c-mark-function' should be rewritten
> >> > to follow the logic of `mark-defun'.
> > Any chance of a quick summary of how c-mark-function differs from
> > mark-defun?
> AFAIK, they differ at least in two things:
> 1. `mark-defun' saves the original point location in the mark ring,
> whereas `c-mark-function' does not. IMO, the point should be saved,
> because in large defuns it may jump to a remote location and you may
> want to return back to the original position. This bug report is
> about this inconsistency, as you can see in the original post.
> 2. Successive interactive invocations of `mark-defun' extend the
> region to the next defuns (which I find useful), whereas
> `c-mark-function' does not have this feature. Bug #5525 is a request
> to remove this inconsistency, as you can see in the corresponding
> thread.
> >> Agreed, and BTW, if `c-mark-function' is going to be revised, please,
> >> take also this problem into account:
> >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525
Here is a patch which should fix these problems. The logic around
transient-mark-mode is somewhat complicated, so I would be grateful if
you would check the patch does the Right Thing. I haven't amended the
doc string yet. Thanks!
diff -r f6961b0b1c51 cc-cmds.el
--- a/cc-cmds.el Fri Mar 02 21:25:40 2012 +0000
+++ b/cc-cmds.el Mon Mar 05 18:35:18 2012 +0000
@@ -1966,8 +1966,20 @@
(if (not decl-limits)
(error "Cannot find any declaration")
- (goto-char (car decl-limits))
- (push-mark (cdr decl-limits) nil t))))
+ (let* ((extend-region-p
+ (or (and (eq this-command 'c-mark-function)
+ (eq last-command 'c-mark-function))))
+ (push-mark-p (and (eq this-command 'c-mark-function)
+ (not extend-region-p)
+ (not (and transient-mark-mode mark-active)))))
+ (if push-mark-p (push-mark (point)))
+ (if extend-region-p
+ (progn
+ (exchange-point-and-mark)
+ (goto-char (cdr (c-declaration-limits t)))
+ (exchange-point-and-mark))
+ (goto-char (car decl-limits))
+ (push-mark (cdr decl-limits) nil t))))))
(defun c-cpp-define-name ()
"Return the name of the current CPP macro, or NIL if we're not in one."
> --
> Dani Moncayo
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2012-03-05 18:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 12:36 bug#10906: 24.0.94; `c-mark-function' does set the mark well Dani Moncayo
2012-02-29 9:02 ` Dani Moncayo
2012-03-01 21:24 ` Alan Mackenzie
2012-03-01 23:03 ` Dani Moncayo
2012-03-01 23:13 ` Alan Mackenzie
2012-03-03 14:16 ` Alan Mackenzie
2012-03-05 18:41 ` Alan Mackenzie [this message]
2012-03-05 22:36 ` Dani Moncayo
2012-03-07 21:09 ` Alan Mackenzie
2012-03-07 21:37 ` Dani Moncayo
2012-03-09 16:49 ` Alan Mackenzie
2012-03-01 23:16 ` Glenn Morris
2012-03-01 23:19 ` Glenn Morris
2012-03-08 11:51 ` bug#10906: Bug #10906 - " Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305184133.GC2824@acm.acm \
--to=acm@muc.de \
--cc=10906@debbugs.gnu.org \
--cc=dmoncayo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.