From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 10664@debbugs.gnu.org
Subject: bug#10664: 24.0.93; JIT font-lock infloops in a C file
Date: Fri, 10 Feb 2012 11:28:57 +0000 [thread overview]
Message-ID: <20120210112857.GA4340@acm.acm> (raw)
In-Reply-To: <jwv1uq586rs.fsf-monnier+emacs@gnu.org>
Hi, Eli and Stefan.
On Wed, Feb 08, 2012 at 02:28:53PM -0500, Stefan Monnier wrote:
> >> > For one particular fontification in socket.c, the "safe position" is 500
> >> > bytes back from the starting point, so jit-lock is pushed back these 500
> >> > bytes, fontifies the next 500 bytes (`jit-lock-chunk-size'), then has its
> >> > new start position set back 500 bytes, rinse, spin, repeat.
> >> Why is "jit-lock pushed back"?
> > Build Emacs revision #106728. emacs -Q, then create the following C++
> > buffer:
> > #########################################################################
> > 1 template <typename T>
> > 2
> > 3
> > 4 void myfunc(T* p) {}
> > #########################################################################
> > This is fontified correctly. Type a space on L2. This is OK for half a
> > second, then context fontification messes up L4. The correct
> > fontification can only be restored by a change to L4.
> That explains why *font-lock* needs to be applied to "L1-L4", but now
> why *jit-lock* needs to be affected.
I was mistaken in my original diagnosis. What is really happening is
that CC Mode is trying to go out of nested parens/brackets to find the
beginning of a declaration.
c-beginning-of-decl-1 (which _never_ goes back outside of
parens/brackets/braces) was given a limit (- (point) 500) which took it
to just after a (. Then we went back out of the (. Then did
c-beginning-of-decl-1 again, which moved _forward_ to the limit. Repeat,
repeat, repeat ad infinitum.
The following patch should fix this. Eli, would you please try it out
and let me know if there are still problems with it.
*** orig/cc-mode.el 2012-02-10 10:55:54.000000000 +0000
--- cc-mode.el 2012-02-10 11:27:56.000000000 +0000
***************
*** 1140,1146 ****
(goto-char (c-point 'bol new-pos))
(when lit-limits ; Comment or string.
(goto-char (car lit-limits)))
! (setq bod-lim (max (- (point) 500) (point-min)))
(while
;; Go to a less nested declaration each time round this loop.
--- 1140,1146 ----
(goto-char (c-point 'bol new-pos))
(when lit-limits ; Comment or string.
(goto-char (car lit-limits)))
! (setq bod-lim (c-determine-limit 500))
(while
;; Go to a less nested declaration each time round this loop.
***************
*** 1158,1168 ****
;; Try and go out a level to search again.
(progn
(c-backward-syntactic-ws bod-lim)
! (or (memq (char-before) '(?\( ?\[))
! (and (eq (char-before) ?\<)
! (eq (c-get-char-property
! (1- (point)) 'syntax-table)
! c-<-as-paren-syntax))))
(not (bobp)))
(backward-char))
new-pos)) ; back over (, [, <.
--- 1158,1169 ----
;; Try and go out a level to search again.
(progn
(c-backward-syntactic-ws bod-lim)
! (and (> (point) bod-lim)
! (or (memq (char-before) '(?\( ?\[))
! (and (eq (char-before) ?\<)
! (eq (c-get-char-property
! (1- (point)) 'syntax-table)
! c-<-as-paren-syntax)))))
(not (bobp)))
(backward-char))
new-pos)) ; back over (, [, <.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2012-02-10 11:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 18:23 bug#10664: 24.0.93; JIT font-lock infloops in a C file Eli Zaretskii
2012-02-05 18:18 ` Eli Zaretskii
2012-02-06 11:09 ` Alan Mackenzie
2012-02-06 14:39 ` Stefan Monnier
2012-02-06 17:04 ` Eli Zaretskii
2012-02-07 17:30 ` Eli Zaretskii
2012-02-07 19:20 ` Alan Mackenzie
2012-02-07 20:58 ` Eli Zaretskii
2012-02-07 21:34 ` Alan Mackenzie
2012-02-07 23:39 ` Stefan Monnier
2012-02-08 11:47 ` Alan Mackenzie
2012-02-08 17:49 ` Eli Zaretskii
2012-02-08 19:28 ` Stefan Monnier
2012-02-10 11:28 ` Alan Mackenzie [this message]
2012-02-12 20:57 ` Eli Zaretskii
2012-02-14 5:42 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210112857.GA4340@acm.acm \
--to=acm@muc.de \
--cc=10664@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.