From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Kazantsev Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications.el: fixed image-data and image-path hints passing Date: Mon, 7 Nov 2011 14:35:32 +0600 Message-ID: <20111107143532.2892852e@malediction> References: <20111107142230.37ce20ec@malediction> <20111107142911.1822efa2@malediction> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/aN5DgirWkPqSMeTXHL8DwY1"; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1320654952 8338 80.91.229.12 (7 Nov 2011 08:35:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2011 08:35:52 +0000 (UTC) Cc: Julien Danjou To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 09:35:44 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RNKgB-0002JS-LH for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2011 09:35:43 +0100 Original-Received: from localhost ([::1]:39671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKgB-0003OC-8N for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2011 03:35:43 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:34171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKg8-0003Nw-Lp for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:35:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNKg7-0001u5-KG for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:35:40 -0500 Original-Received: from mail-ey0-f169.google.com ([209.85.215.169]:64902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKg7-0001u1-EW for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:35:39 -0500 Original-Received: by eye4 with SMTP id 4so3630952eye.0 for ; Mon, 07 Nov 2011 00:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=2f2zbIGy0jjaqXy5VIEFlbVYGZPt1KGxjKwhVR1nQUA=; b=GQA0yWe82UeJ3YhP1xeMy6B6qLcrYjMBbNUWCmuEtFnRhNN25XBqEW88lc+MaP92gg qKWvVoo1c2FyNRbro/8jcsb4u6kduEL/DBVNPD+0Xmd1q5lsctln7leBGdsqPleT+7jM RN3kHKTYDqtTwdoW2QSTaqM3TBF/taE5gDa3I= Original-Received: by 10.14.10.67 with SMTP id 43mr2056359eeu.140.1320654937251; Mon, 07 Nov 2011 00:35:37 -0800 (PST) Original-Received: from malediction (wall.mplik.ru. [195.58.1.141]) by mx.google.com with ESMTPS id d6sm48232562eec.10.2011.11.07.00.35.35 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Nov 2011 00:35:36 -0800 (PST) In-Reply-To: <20111107142911.1822efa2@malediction> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.7; i686-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.215.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145921 Archived-At: --Sig_/aN5DgirWkPqSMeTXHL8DwY1 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 7 Nov 2011 14:29:11 +0600 Mike Kazantsev wrote: > On Mon, 7 Nov 2011 14:22:30 +0600 > Mike Kazantsev wrote: >=20 > >=20 > > Good day, > >=20 > > Before the patch, hints were passed as "image_path" and "image_data", > > which is incorrect, as Desktop Notifications Specification v1.2 clearly > > states: > >=20 > > The icon is defined by the "app_icon" parameter. The image can be > > defined by the "image-path", the "image-data" hint or the deprecated > > "icon_data" hint. > >=20 > > Most common (by far) implementation of spec - libnotify - seem to pass > > them as described in spec as well, so current behavior looks like a bug. > >=20 >=20 > Actually looking at previous spec versions (which can be found on > http://www.galago-project.org/specs/notification/), there seemed to be > an "icon_data" hint in 0.9, but not "icon_path", so I can guess that's > where these came from. >=20 > Mentioned specs seem to be fairly obsolete now, and even if they > should be supported, there doesn't seem to be any excuse to pass > "icon_path". >=20 Hmm... and looking further at 1.1, which is mentioned a bit below in the code, and even set as "notifications-specification-version", I see that current implementation is actually correct. Terribly sorry for the confusion and the noise, should've checked the specs more closely. Desktop Notifications Specification 1.1: http://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1= .1.html P.S. Link to galago-project.org at the top of the module seem to be bogus though - specs there only cover versions up to 0.9, but I guess it's not worth a separate fix. >=20 > > Patch to pass "image-path" and "image-data" hints - as per spec - is > > attached below. > >=20 > > Desktop Notifications Specification: > >=20 > > http://developer.gnome.org/notification-spec/#icons-and-images > > http://people.gnome.org/~mccann/docs/notification-spec/notification-s= pec-latest.html#icons-and-images > >=20 > ... >=20 >=20 --=20 Mike Kazantsev // fraggod.net --Sig_/aN5DgirWkPqSMeTXHL8DwY1 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iEYEARECAAYFAk63mFQACgkQASbOZpzyXnHJxQCeNFz5wOtLLos01y0wJjmJkejV ZcMAoJU12OupcMVnYmDbzLCZUEXHj38b =qEKD -----END PGP SIGNATURE----- --Sig_/aN5DgirWkPqSMeTXHL8DwY1--